Improve unit test coverage of AccountDelete transactor #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgramkumar
approved these changes
Apr 20, 2021
intelliot
approved these changes
Apr 21, 2021
scottschurr
added
the
Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds unit tests for the
AccountDeletetransactor to improve coverage.Context of Change
While reading through the
AccountDeletetransactor source code for other reasons, I thought I spotted a potential bug. And I saw, when running code coverage locally, that the case I was wondering about was not exercised by the unit tests.So I added a unit test to cover the case I was wondering about (it ended up the there was no bug). Then I added more unit tests to try and make the
AccountDeletecode coverage as complete as is reasonable.Type of Change
This change only adds unit tests, so there's no reason to mention the changes in the release notes.