Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account and owner reserve #3951

Closed
wants to merge 1 commit into from
Closed

Update account and owner reserve #3951

wants to merge 1 commit into from

Conversation

alloynetworks
Copy link
Contributor

Update defaults from 20/5 to 10/2 for account and owner reserves respectively. The network has been voting for 10/2 for an adequate period of time and a new server installation should default to the new reserves.

Update defaults from 20/5 to 10/2 for account and owner reserves respectively. The network has been voting for 10/2 for an adequate period of time and a new server installation should default to the new reserves.
@MarkusTeufelberger
Copy link
Collaborator

There should be no default vote in my opinion... the correct defaults are here: https://github.com/ripple/rippled/blob/8a25f3282426f382e1933242ef875d5aaf3e31e9/src/ripple/core/Config.h#L174-L175

@alloynetworks
Copy link
Contributor Author

There should be no default vote in my opinion... the correct defaults are here:

https://github.com/ripple/rippled/blob/8a25f3282426f382e1933242ef875d5aaf3e31e9/src/ripple/core/Config.h#L174-L175

Thanks for pointing this out. I didn’t realize it was in another location too.

I do agree with you that a hard coded default isn’t the best solution but I can’t think of how to ensure a non zero value without that.

@MarkusTeufelberger
Copy link
Collaborator

Remove the default vote, leave in the default value and add a value representing the current fee structure on XRPL to the default config file since running rippled as a server for XRPL is likely the most common use case.

@manojsdoshi manojsdoshi mentioned this pull request Oct 18, 2021
@manojsdoshi
Copy link
Contributor

@alloynetworks this PR is causing unit tests to fail. Can you please look into them?
Failing job https://app.travis-ci.com/github/ripple/rippled/builds/239550425

@alloynetworks alloynetworks deleted the patch-1 branch February 18, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants