Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Remove checks for CMake < 3.16 #4124

Closed
wants to merge 2 commits into from
Closed

[Trivial] Remove checks for CMake < 3.16 #4124

wants to merge 2 commits into from

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Mar 24, 2022

High Level Overview of Change

Removes all conditional code for CMake < 3.16 that will never get hit.

Context of Change

CMake 3.16 or higher is required now so all this is cruft.

Type of Change

  • Refactor (non-breaking change that only restructures code)

@legleux
Copy link
Collaborator Author

legleux commented Mar 24, 2022

Should I add this to .git-blame-ignore-revs?

thejohnfreeman
thejohnfreeman reviewed Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@thejohnfreeman thejohnfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more than a formatting change, so please do not add it to the ignored commits. Do we have a pending PR for the Visual Studio 64-bit check? If not, can we add it to this?

@legleux legleux requested a review from manojsdoshi March 25, 2022 18:44
manojsdoshi
manojsdoshi approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manojsdoshi manojsdoshi mentioned this pull request Mar 30, 2022
Merged
@legleux legleux deleted the ml/remove-cmake-version-checks branch January 17, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnfreeman thejohnfreeman thejohnfreeman left review comments

@manojsdoshi manojsdoshi manojsdoshi approved these changes

@seelabs seelabs Awaiting requested review from seelabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legleux @thejohnfreeman @manojsdoshi