Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Lower log level of "addPathsForType" log message: #4178

Closed
wants to merge 1 commit into from
Closed

[TRIVIAL] Lower log level of "addPathsForType" log message: #4178

wants to merge 1 commit into from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented May 24, 2022

High Level Overview of Change

Per #4177, the log level for Pathfinder:WRN addPathsForType appears to be too verbose. It should be downgraded from warning to debug or trace level.

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)

Test Plan

  • Run rippled with the log level set to "WRN" for all components.
  • Submit a path_find request
  • With version 1.9.1, there will be many messages starting with "Pathfinder:WRN addPathsForType"
  • With this change, there won't be any of those messages.

@ximinez ximinez requested a review from mDuo13 May 24, 2022 21:50
@ximinez ximinez added the Bug label May 24, 2022
@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 25, 2022
@nbougalis nbougalis mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@intelliot intelliot intelliot approved these changes

Assignees

@mDuo13 mDuo13

Labels
Bug Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ximinez @intelliot @mDuo13