Fix race conditions in shard #4188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThreadSafetyAnalysis was used to identify race conditions in this file. This analysis was modivated by a (rare) crash while running unit tests. Add locks to Shard flagged by ThreadSafetyAnalysis
scottschurr
approved these changes
Jun 6, 2022
| @@ -316,29 +318,30 @@ class Shard final | |||
| boost::filesystem::path const dir_; | |||
|
|
|||
| // Storage space utilized by the shard | |||
| std::uint64_t fileSz_{0}; | |||
| GUARDED_BY(mutex_) std::uint64_t fileSz_{0}; | |||
There was a problem hiding this comment.
I really like this annotation! Could not be clearer.
There was a problem hiding this comment.
As a side note: one down side to these annotations being bolted-on and not part of the language is we usually put the annotations at the end of a declaration, but when the variable is initialized, we need to put it at the beginning. That's unfortunate, but not a killer.
undertome
suggested changes
Jun 6, 2022
|
@undertome, has @seelabs addressed your concerns? |
yes |
undertome
approved these changes
Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR introduces two changes:
ThreadSafetyAnalysisTo compile with
ThreadSafetyAnalysis, compile with clang and use-Dthread_safety_analysis=Onwith cmake. Note: this will compile with clang's standard library and may not link. This is OK, we are running this for the compile warnings, not for the executable.This would be a good PR to discuss objections to the annotations required by
ThreadSafetyAnalysisType of Change