Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit how often endpoint messages can be processed: #4202

Closed
wants to merge 1 commit into from
Closed

Limit how often endpoint messages can be processed: #4202

wants to merge 1 commit into from

Conversation

nbougalis
Copy link
Contributor

The peer discovery protocol depends on peers exchanging messages listing IP addresses for other peers.

Under normal circumstances, these messages should not be sent frequently; the existing code would track the earliest time a new message should be processed, but did not actually enforce that limit.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@nbougalis
Limit how often endpoint messages can be processed:
41d9c2c 
The peer discovery protocol depends on peers exchanging messages
listing IP addresses for other peers.

Under normal circumstances, these messages should not be sent
frequently; the existing code would track the earliest time a
new message should be processed, but did not actually enforce
that limit.
@nbougalis nbougalis added the Bug label Jun 9, 2022
seelabs
seelabs approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@nbougalis nbougalis mentioned this pull request Jul 11, 2022
Merged
@nbougalis nbougalis deleted the epl branch October 16, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardHinnant HowardHinnant HowardHinnant approved these changes

@seelabs seelabs seelabs approved these changes

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

Assignees

@thejohnfreeman thejohnfreeman

@seelabs seelabs

@HowardHinnant HowardHinnant

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbougalis @thejohnfreeman @seelabs @HowardHinnant