Work around soci build issues #4246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
added
Build System
Dependencies
|
Requesting a review from @seelabs, who I can't assign, because he came up with the original patch. |
thejohnfreeman
approved these changes
Aug 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Soci's CMake setup leaves flags in place that will cause warnings to
be treated as errors, but some compiler versions throw "new" warnings
that then cause the build to fail. Simplify that until soci fixes
those warnings.
Note that this PR will probably become obsolete if / when #4223 is merged.
Context of Change
This only affects the build process for the soci dependency.
Type of Change
Before / After
Before this change, the soci cmake file would need to be patched manually before being able to successfully build with an affected compiler (clang 14, maybe others). After, the build should proceed seamlessly.