Prevent unnecessary shared_ptr copies by accepting a value in SHAMapInnerNode::setChild
#4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
force-pushed
the
shamap_setchild
branch
from
afda282 to
397f5ef
Compare
nbougalis
suggested changes
Aug 9, 2022
nbougalis
approved these changes
Aug 29, 2022
nbougalis
added
the
Passed
intelliot
removed
the
Passed
|
(note from discussion: we'd like 1 more review of this) |
seelabs
approved these changes
Nov 28, 2022
intelliot
added
the
Passed
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
…apInnerNode::setChild` (XRPLF#4266) * Do a move instead of a copy in `SHAMapInnerNode::setChild` * Create the value directly in the call
tequdev
pushed a commit
to tequdev/rippled
that referenced
this pull request
Nov 17, 2023
…apInnerNode::setChild` (XRPLF#4266) * Do a move instead of a copy in `SHAMapInnerNode::setChild` * Create the value directly in the call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Because
SHAMapInnerNode::setChildtakes ashared_ptr const &, every node insertion requires a shared_ptr copy, which causes an increment/decrement of the refcount in the object. This PR makesSHAMapInnerNode::setChildtake a value which is moved into place.Context of Change
Type of Change
This does not cause any functional change.