Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for invalid memos #4287

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

scottschurr
Copy link
Collaborator

High Level Overview of Change

While reviewing a different pull request I noted that the code coverage of memos is not as good as it could be. So I wrote a unit test to improve that coverage.

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean set of tests.

@intelliot intelliot requested a review from a team December 20, 2022 00:22
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One note - it didn't build for me with boost 1.80.0 (built with 1.75.0). On OSX I got this type of error:
src/ripple/beast/container/detail/aged_ordered_container.h:1435:53: error: no member named 'comp' in 'boost::intrusive::set_impl<boost::intrusive::bhtraits<beast::detail::aged_ordered_container<false, false, std::string, void, std::chrono::steady_clock, std::lessstd::string, std::allocatorstd::string>::element, boost::intrusive::rbtree_node_traits<void *, false>, boost::intrusive::normal_link, boost::intrusive::dft_tag, 3>, void, beast::detail::aged_ordered_container<false, false, std::string, void, std::chrono::steady_clock, std::lessstd::string, std::allocatorstd::string>::KeyValueCompare, unsigned long, true, void>'
: m_config(other.m_config), m_cont(other.m_cont.comp())

Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built on macOS

@intelliot
Copy link
Collaborator

CI failure is 0> #3 failed: NodeToShardRPC_test.cpp(47) which is known to be flaky

@intelliot intelliot merged commit 61d8c7a into XRPLF:develop Jan 4, 2023
ximinez added a commit to ximinez/rippled that referenced this pull request Jan 5, 2023
* upstream/develop:
  Add a unit test for invalid memos (XRPLF#4287)
ximinez added a commit to ximinez/rippled that referenced this pull request Jan 5, 2023
* upstream/develop:
  Add a unit test for invalid memos (XRPLF#4287)
ximinez added a commit to ximinez/rippled that referenced this pull request Jan 5, 2023
* upstream/develop:
  Add a unit test for invalid memos (XRPLF#4287)
ximinez added a commit to ximinez/rippled that referenced this pull request Jan 5, 2023
* upstream/develop:
  Add a unit test for invalid memos (XRPLF#4287)
ximinez added a commit to ximinez/rippled that referenced this pull request Jan 5, 2023
* upstream/develop:
  Add a unit test for invalid memos (XRPLF#4287)
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Jan 24, 2023
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants