-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a unit test for invalid memos #4287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean set of tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One note - it didn't build for me with boost 1.80.0 (built with 1.75.0). On OSX I got this type of error:
src/ripple/beast/container/detail/aged_ordered_container.h:1435:53: error: no member named 'comp' in 'boost::intrusive::set_impl<boost::intrusive::bhtraits<beast::detail::aged_ordered_container<false, false, std::string, void, std::chrono::steady_clock, std::lessstd::string, std::allocatorstd::string>::element, boost::intrusive::rbtree_node_traits<void *, false>, boost::intrusive::normal_link, boost::intrusive::dft_tag, 3>, void, beast::detail::aged_ordered_container<false, false, std::string, void, std::chrono::steady_clock, std::lessstd::string, std::allocatorstd::string>::KeyValueCompare, unsigned long, true, void>'
: m_config(other.m_config), m_cont(other.m_cont.comp())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully built on macOS
CI failure is |
* upstream/develop: Add a unit test for invalid memos (XRPLF#4287)
* upstream/develop: Add a unit test for invalid memos (XRPLF#4287)
* upstream/develop: Add a unit test for invalid memos (XRPLF#4287)
* upstream/develop: Add a unit test for invalid memos (XRPLF#4287)
* upstream/develop: Add a unit test for invalid memos (XRPLF#4287)
High Level Overview of Change
While reviewing a different pull request I noted that the code coverage of memos is not as good as it could be. So I wrote a unit test to improve that coverage.
Type of Change