Rectify the import paths of boost::function_output_iterator #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardHinnant
approved these changes
Feb 16, 2023
…ckeshava-cmakeBoostWarning
|
LGTM |
drlongle
approved these changes
Feb 23, 2023
|
@ckeshava: At your convenience, please comment here to confirm that, from your perspective, this PR is ready to merge. |
|
@intelliot Hello, it looks okay to me. I don't have the toolchain to unit-test this change with the most recent version of develop. If the unit tests are working correctly, then it can be merged. I'm hoping there haven't been any changes to boost or rippled's compatibility. |
intelliot
added
the
Passed
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
* upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
* upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
* upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
* upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
* upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
…ctionality * upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 15, 2023
…tpage * upstream/develop: Rectify the import paths of boost/iterator: (XRPLF#4293) Allow port numbers be be specified with a colon: (XRPLF#4328) Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411) Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rectify the import paths of boost/iterator as suggested by compiler warnings
High Level Overview of Change
MSVC 19.x reports a warning about import paths in boost for function_output_iterator class. This commit aims to eliminate that warning by updating the import paths.