Code

Introduce AMM support (XLS-30d)#4294

Code

Merged

intelliot merged 62 commits intoXRPLF:developXRPLF/rippled:developfrom gregtatcam:amm-core-functionalitygregtatcam/rippled:amm-core-functionalityCopy head branch name to clipboardJul 12, 2023

+18,092-649

Commits

Commits on Apr 28, 2023

• Introduce AMM support (XLS-30d)

  gregtatcam

  committed
  6dc93d0

  Copy full SHA for 6dc93d0

• [FOLD] Use average quality for one path optimization. Fix ammAccountHolds(). Update unit-tests.

  gregtatcam

  committed
  101e3e0

  Copy full SHA for 101e3e0

• [FOLD] Make deterministic voting slot ordering in case of the same voting weights and fee. Update voting unit-test. Fix AuthAccounts field conflict with sfXChainProofSigs.

  gregtatcam

  committed
  ecb7d9d

  Copy full SHA for ecb7d9d

• [FOLD] Fix AMMInstanceCreate with self-issued token.

  gregtatcam

  committed
  f89e44d

  Copy full SHA for f89e44d

• [FOLD] Return tecNO_[AUTH|LINE] in requireAuth(). Simplify AMM unit-tests input data. Tentatively complete AMM Offer unit-tests. Start AMM Path unit-tests. Remove AMM manual test.

  gregtatcam

  committed
  b6befdb

  Copy full SHA for b6befdb

• [FOLD] Add AMM support for the transfer fee.

  gregtatcam

  committed
  7c53e89

  Copy full SHA for 7c53e89

• [FOLD] Fix non-unity build.

  gregtatcam

  committed
  1cf3f28

  Copy full SHA for 1cf3f28

• [FOLD] Address review comments:

  Show description for ad07933
  gregtatcam

  committed
  ad07933

  Copy full SHA for ad07933

• [FOLD]

  Show description for 479ee4f
  gregtatcam

  committed
  479ee4f

  Copy full SHA for 479ee4f

• [FOLD]

  Show description for 35ebb71
  gregtatcam

  committed
  35ebb71

  Copy full SHA for 35ebb71

• [FOLD]

  Show description for db36c91
  gregtatcam

  committed
  db36c91

  Copy full SHA for db36c91

• [FOLD] Roll back (temp) AMM index.

  gregtatcam

  committed
  fa404e0

  Copy full SHA for fa404e0

• [FOLD] Replace AMMID with asset pair and other changes

  Show description for ff664b4
  gregtatcam

  committed
  ff664b4

  Copy full SHA for ff664b4

• [FOLD] Rename Max/MinBidPrice to BidMax/Min and other changes.

  Show description for 93a85a3
  gregtatcam

  committed
  93a85a3

  Copy full SHA for 93a85a3

• [FOLD] Fix valid range for Deposit/Withdraw flags and update Withdraw subTx.

  gregtatcam

  committed
  b55aa43

  Copy full SHA for b55aa43

• [FOLD] Resolve sfAsset/sfAsset2 fieldValue conflict with the sidechain PR.

  gregtatcam

  committed
  e4b2986

  Copy full SHA for e4b2986

• [FOLD] Resolve merge conflict with 1.10.0-b2

  gregtatcam

  committed
  c81c370

  Copy full SHA for c81c370

• [FOLD] Fix amm_info crash and other changes

  Show description for c6ffd7d
  gregtatcam

  committed
  c6ffd7d

  Copy full SHA for c6ffd7d

• [FOLD] Address @godexsoft comments and other changes

  Show description for 5b3dba9
  gregtatcam

  committed
  5b3dba9

  Copy full SHA for 5b3dba9

• [FOLD] Adjust tokens for precision loss in deposit and withdraw and other changes

  Show description for 33c3530
  gregtatcam

  committed
  33c3530

  Copy full SHA for 33c3530

• [FOLD] Move clio related functions to xrpl_core and other changes

  Show description for 4c695f6
  gregtatcam

  committed
  4c695f6

  Copy full SHA for 4c695f6

• [FOLD] Set AMM creator's fee voting and action slots and other changes

  Show description for c97ed40
  gregtatcam

  committed
  c97ed40

  Copy full SHA for c97ed40

• Remove the fee from the spot price equation and other changes

  Show description for 853d644
  gregtatcam

  committed
  853d644

  Copy full SHA for 853d644

• [FOLD] Resolve merge conflict with 1.10.0-rc4 and minor clean up.

  gregtatcam

  committed
  79e1627

  Copy full SHA for 79e1627

• [FOLD] Address reviewer feedback and other changes

  Show description for b4d3565
  gregtatcam

  committed
  b4d3565

  Copy full SHA for b4d3565

• [FOLD] Address reviewer feedback

  Show description for 4ba1bc3
  gregtatcam

  committed
  4ba1bc3

  Copy full SHA for 4ba1bc3

• [FOLD] Rename wavesTransferFee() to waivesTransferFee()

  gregtatcam

  committed
  33a853e

  Copy full SHA for 33a853e

• [FOLD] Address reviewer feedback

  Show description for 9b6f04b
  gregtatcam

  committed
  9b6f04b

  Copy full SHA for 9b6f04b

• [FOLD] Update Copyright on all new AMM files.

  gregtatcam

  committed
  81eec0d

  Copy full SHA for 81eec0d

• [FOLD] Rename sfAMMAccount to sfAccount and update amm_info.

  gregtatcam

  committed
  22e3370

  Copy full SHA for 22e3370

• [FOLD] Consistently handle global and individual freeze and other changes

  Show description for cf385ff
  gregtatcam

  committed
  cf385ff

  Copy full SHA for cf385ff

• [FOLD] Fix unit-test merge conflicts

  gregtatcam

  committed
  f99260f

  Copy full SHA for f99260f

• [FOLD] Improve Fibonnaci AMM offer generation performance and minor refactoring

  gregtatcam

  committed
  1c6c38c

  Copy full SHA for 1c6c38c

• [FOLD] Add comments to clarify single deposit/withdrawal with effective price.

  gregtatcam

  committed
  67a37ad

  Copy full SHA for 67a37ad

• [FOLD] Move fee functions to AMMCore.h and other changes

  Show description for ccd1843
  gregtatcam

  committed
  ccd1843

  Copy full SHA for ccd1843

• [FOLD] Make sfDiscountedFee and sfTradingFee as soeDEFAULT in ltAMM and other changes

  Show description for d1da8d9
  gregtatcam

  committed
  d1da8d9

  Copy full SHA for d1da8d9

• [FOLD] Fix sfTradingFee and sfDiscountedFee fields access and other changes

  Show description for 76b6b48
  gregtatcam

  committed
  76b6b48

  Copy full SHA for 76b6b48

• [FOLD] Fix bid pay price exceeding lp tokens

  gregtatcam

  committed
  04f54ec

  Copy full SHA for 04f54ec

• [FOLD] Address amm info and payment engine reviewer's feedback

  gregtatcam

  committed
  e443b78

  Copy full SHA for e443b78

Commits on May 2, 2023

• [FOLD] Address amm unit-tests reviewer's feedback

  gregtatcam

  committed
  6dd5f02

  Copy full SHA for 6dd5f02

• [FOLD] Split AMM_test.cpp into multiple files and remove duplicate helper functions.

  gregtatcam

  committed
  c53df03

  Copy full SHA for c53df03

Commits on May 3, 2023

• [FOLD] Remove unneeded BEAST_EXPECT() left in unit-test run() from some debugging.

  gregtatcam

  committed
  2bf02a2

  Copy full SHA for 2bf02a2

Commits on May 11, 2023

• [FOLD] Address reviewer's feedback and other changes

  Show description for 5dc86be
  gregtatcam

  committed
  5dc86be

  Copy full SHA for 5dc86be

Commits on May 22, 2023

• [FOLD] Address reviewer's feedback and other changes

  Show description for e3339de
  gregtatcam

  committed
  e3339de

  Copy full SHA for e3339de

• Ensure that switchover vars are initialized before use:

  Show description for 02d5db6
  

  seelabs

  authored and

  gregtatcam

  committed
  02d5db6

  Copy full SHA for 02d5db6

Commits on May 31, 2023

• [FOLD] Address auditor's feedback

  Show description for c2692d9
  gregtatcam

  committed
  c2692d9

  Copy full SHA for c2692d9

Commits on Jun 1, 2023

• [FOLD] Update trading fee unit-tests; update comments

  gregtatcam

  committed
  69a93a3

  Copy full SHA for 69a93a3

Commits on Jun 4, 2023

• [FOLD] Address reviewer's feedback

  Show description for ad81c4b
  gregtatcam

  committed
  ad81c4b

  Copy full SHA for ad81c4b

Commits on Jun 7, 2023

• [FOLD] Address reviewer's feedback

  Show description for d9080e3
  gregtatcam

  committed
  d9080e3

  Copy full SHA for d9080e3

• [FOLD] Fix sfAuthAccounts conflict with side-chains

  gregtatcam

  committed
  ed920c0

  Copy full SHA for ed920c0

Commits on Jun 8, 2023

• [FOLD] Consolidate all tecAMM_FAILED_* as tecAMM_FAILED and other changes

  Show description for b6d3301
  gregtatcam

  committed
  b6d3301

  Copy full SHA for b6d3301

Commits on Jun 14, 2023

• [FOLD] Add optional min deposit parameters to AMMDeposit and other changes

  Show description for 39cb731
  gregtatcam

  committed
  39cb731

  Copy full SHA for 39cb731

Commits on Jun 15, 2023

• [FOLD] Disallow AMMCreate if a token issuer's account has DefaultRipple disabled

  gregtatcam

  committed
  1860e33

  Copy full SHA for 1860e33

• [FOLD] Address reviewer's feedback

  gregtatcam

  committed
  1d5af43

  Copy full SHA for 1d5af43

Commits on Jun 21, 2023

• [FOLD] Address reviewer's feedback

  gregtatcam

  committed
  4741cb4

  Copy full SHA for 4741cb4

Commits on Jun 22, 2023

• [FOLD] Take into account the transfer fee in balance check on create/deposit.

  gregtatcam

  committed
  74e5762

  Copy full SHA for 74e5762

Commits on Jun 30, 2023

• Revert "[FOLD] Take into account the transfer fee in balance check on create/deposit."

  Show description for d79dbe3
  gregtatcam

  committed
  d79dbe3

  Copy full SHA for d79dbe3

• [FOLD] Remove the transfer fee from create/deposit and other changes

  Show description for a6fc4dc
  gregtatcam

  committed
  a6fc4dc

  Copy full SHA for a6fc4dc

Commits on Jul 9, 2023

• [FOLD] Address reviewers feedback

  Show description for 6e26310
  gregtatcam

  committed
  6e26310

  Copy full SHA for 6e26310

Commits on Jul 10, 2023

• [FOLD] Address reviewer feedback

  Show description for 515353f
  gregtatcam

  committed
  515353f

  Copy full SHA for 515353f

Commits on Jul 11, 2023

• [FOLD] Merge with the latest develop

  gregtatcam

  committed
  902af50

  Copy full SHA for 902af50

Commits on Jul 12, 2023

• [FOLD] Merge with develop to fix change in Conan recipe for NuDB

  gregtatcam

  committed
  84b0f86

  Copy full SHA for 84b0f86