Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway_balances): handle overflow exception #4355

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix(gateway_balances): handle overflow exception #4355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0464f
catch overflow exception in gateway_balances
RichardAH Nov 30, 2022
36ffe0c
[FOLD] Treat gateway_balances obligations overflow as max STAmount
scottschurr Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ripple/protocol/jss.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ JSS(open); // out: handlers/Ledger
JSS(open_ledger_cost); // out: SubmitTransaction
JSS(open_ledger_fee); // out: TxQ
JSS(open_ledger_level); // out: TxQ
JSS(overflow); // out: gateway_balances
JSS(owner); // in: LedgerEntry, out: NetworkOPs
JSS(owner_funds); // in/out: Ledger, NetworkOPs, AcceptedLedgerTx
JSS(page_index);
Expand Down
11 changes: 10 additions & 1 deletion src/ripple/rpc/handlers/GatewayBalances.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,16 @@ doGatewayBalances(RPC::JsonContext& context)
bal = -rs->getBalance();
}
else
bal -= rs->getBalance();
{
try
{
bal -= rs->getBalance();
}
catch (std::runtime_error& e)
{
result[jss::overflow] = "true";
}
}
}
});
}
Expand Down