Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Conan package manager #4367

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

thejohnfreeman
Copy link
Collaborator

This is a signed, squashed commit capturing all of the changes in #4223.

@intelliot
Copy link
Collaborator

Even though this is the same as #4223, let's get a quick look from one of the other reviewers before we merge this in.

@intelliot intelliot added Build System Dependencies Issues associated with 3rd party dependencies (RocksDB, SQLite, etc) High Priority Will Need Documentation labels Dec 14, 2022
@intelliot
Copy link
Collaborator

@mDuo13 are there any docs on XRPL.org that should be updated?

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to using this full time! Adios .nih_c folder!

We use the <concepts> library which was not added to Apple Clang until
version 13.1.6. The default Clang on macos-11 (the sometimes current
version of macos-latest) is 13.0.0, and the default Clang on macos-12 is
14.0.0.
@intelliot intelliot merged commit c3a9f3d into XRPLF:develop Dec 16, 2022
@thejohnfreeman thejohnfreeman deleted the merge-conan branch December 20, 2022 18:50
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Dec 27, 2022
Introduces a conanfile.py (and a Conan recipe for RocksDB) to enable building the package with Conan, choosing more recent default versions of dependencies. It removes almost all of the CMake build files related to dependencies, and the configurations for Travis CI and GitLab CI. A new set of cross-platform build instructions are written in BUILD.md.

Includes example GitHub Actions workflow for each of Linux, macOS, Windows.

* Test on macos-12

We use the <concepts> library which was not added to Apple Clang until
version 13.1.6. The default Clang on macos-11 (the sometimes current
version of macos-latest) is 13.0.0, and the default Clang on macos-12 is
14.0.0.

Closes XRPLF#4223.
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
Introduces a conanfile.py (and a Conan recipe for RocksDB) to enable building the package with Conan, choosing more recent default versions of dependencies. It removes almost all of the CMake build files related to dependencies, and the configurations for Travis CI and GitLab CI. A new set of cross-platform build instructions are written in BUILD.md.

Includes example GitHub Actions workflow for each of Linux, macOS, Windows.

* Test on macos-12

We use the <concepts> library which was not added to Apple Clang until
version 13.1.6. The default Clang on macos-11 (the sometimes current
version of macos-latest) is 13.0.0, and the default Clang on macos-12 is
14.0.0.

Closes XRPLF#4223.
tequdev pushed a commit to tequdev/rippled that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System Dependencies Issues associated with 3rd party dependencies (RocksDB, SQLite, etc) Will Need Documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants