Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update "Build from source" section #4426

Merged
merged 4 commits into from
Feb 21, 2023
Merged

README: Update "Build from source" section #4426

merged 4 commits into from
Feb 21, 2023

Conversation

intelliot
Copy link
Collaborator

@intelliot intelliot commented Feb 18, 2023

High Level Overview of Change

Many developers and new contributors expect to find a link to the build instructions in the README.

Context of Change

The current README has 3 links: 2 go to obsolete files, and 1 is broken. This PR replaces all 3 with a link to the current instructions, and updates the 3 locations that the existing links point to - such that they are single-line files that just link to the current instructions.

Fix #2987.

Type of Change

  • Documentation Updates

Note: This PR will be squashed when merged.

@intelliot intelliot added Documentation README changes, code comments, etc. Trivial labels Feb 18, 2023
@intelliot intelliot merged commit 5ec8783 into develop Feb 21, 2023
@intelliot intelliot deleted the readme-build branch February 21, 2023 23:40
legleux pushed a commit to legleux/rippled that referenced this pull request Feb 22, 2023
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
…ctionality

* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
  README: Add a few source code starting points (XRPLF#4421)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 23, 2023
…tpage

* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
  README: Add a few source code starting points (XRPLF#4421)
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation README changes, code comments, etc. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README should contain link to in-repo build-doc
2 participants