-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Update "Build from source" section #4426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this file to fix some previously broken links
justinr1234
approved these changes
Feb 18, 2023
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Feb 22, 2023
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
* upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
…ctionality * upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426) README: Add a few source code starting points (XRPLF#4421)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 23, 2023
…tpage * upstream/develop: Fix Conan version constraint in workflows (XRPLF#4430) Refactor getTrustedForLedger() (XRPLF#4424) README: Update "Build from source" section (XRPLF#4426) README: Add a few source code starting points (XRPLF#4421)
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Many developers and new contributors expect to find a link to the build instructions in the README.
Context of Change
The current README has 3 links: 2 go to obsolete files, and 1 is broken. This PR replaces all 3 with a link to the current instructions, and updates the 3 locations that the existing links point to - such that they are single-line files that just link to the current instructions.
Fix #2987.
Type of Change
Note: This PR will be squashed when merged.