Make it easy for projects to depend on libxrpl #4449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset does a few things:
ALIAS
target namedxrpl::libxrpl
for projects to link.xrpl_core
. There is no other "non-core" library target against which we need to distinguish the "core" library. We only export one library target, and it should just be named after the project to keep things simple and predictable. (I think underscores in target or library names are generally discouraged anyway.) Every target exported in CMake should be prefixed with the project name. The project should not be named after the company Ripple. I think most of us prefer to just name it after the ledger.ALIAS
target, existing consumers who use thexrpl_core
target will not be affected. In the future, we can start a migration plan to makexrpl_core
theALIAS
target (andlibxrpl
the "real" target, which will affect the filename of the compiled binary), and eventually remove it entirely.xrpl::libxrpl
. This way, every consumer can use the same instructions.See #4443.