-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Linux test matrix #4454
Expand Linux test matrix #4454
Conversation
We may not need it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
notes:
|
Looks good to me. |
cc: /usr/bin/clang-14 | ||
cxx: /usr/bin/clang++-14 | ||
runs-on: [self-hosted, heavy] | ||
container: thejohnfreeman/rippled-build-ubuntu:12e19cd9034b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe push a new ubuntu 18.04 image with GCC-10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 18.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can test it into perpetuity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I think there's a case to be made to pick one configuration to test on multiple versions of Ubuntu. I don't have an 18.04 image with everything available right now. Won't take me long to make one, but perhaps we can punt that to a future PR?
I think this is ready to merge with this message:
|
This change makes progress on the goal of #4371. It does not replicate the full matrix implemented in #3851, but it does replicate the 1.ii section of the Linux matrix. It leverages our "heavy" self-hosted runners and my Docker image for a rippled build environment, and demonstrates what I believe is a simple, readable pattern for future matrices.