Fix package definition for Conan #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, can you share example(s) of projects that could (or should) use the project package - and therefore use this fixed package definition? |
intelliot
reviewed
Apr 12, 2023
| @@ -6,8 +6,8 @@ | |||
|
|
|||
| #include <string.h> | |||
|
|
|||
| #include "include/secp256k1.h" | |||
There was a problem hiding this comment.
note: paths work when building within our codebase but not the source as it would be installed on the system
intelliot
reviewed
Apr 12, 2023
| @@ -153,6 +153,7 @@ install ( | |||
| src/ripple/basics/Blob.h | |||
| src/ripple/basics/Buffer.h | |||
| src/ripple/basics/CountedObject.h | |||
| src/ripple/basics/Expected.h | |||
There was a problem hiding this comment.
note: we forgot to add this to the cmake headers - doesn't affect us since we build in our codebase, but others depending on libxrpl would run into this.
this makes it possible for others to depend on libxrpl
|
note: fairly light review - mostly changing include paths. if needed, @thejohnfreeman could walk through what's changing and why |
|
@seelabs to look |
|
@legleux would you be able to review this? |
|
LGTM 👍 |
legleux
approved these changes
May 30, 2023
thejohnfreeman
added
the
Passed
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Jul 10, 2023
Fix the libxrpl library target for consumers using Conan. * Fix installation issues and update includes. * Update requirements in the Conan package info. * libxrpl requires openssl::crypto. (Conan is a software package manager for C++.)
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Fix the libxrpl library target for consumers using Conan. * Fix installation issues and update includes. * Update requirements in the Conan package info. * libxrpl requires openssl::crypto. (Conan is a software package manager for C++.)
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Fix the libxrpl library target for consumers using Conan. * Fix installation issues and update includes. * Update requirements in the Conan package info. * libxrpl requires openssl::crypto. (Conan is a software package manager for C++.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project doesn't quite install itself correctly.