-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(BUILD): make it easier to find environment.md #4507
Conversation
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK your thoughts. I can work on modifying this document.
@ckeshava feel free to propose other changes to this document, as you like. |
It looks good to me. I'm curious: Are there any plans to provide a DockerFile for people to spin up the rippled executable? It might not be suitable for development environment, but it might simplify the user experience for only maintaining a validator on the ledger. |
@ckeshava re: Dockerfile, does this provide what you're looking for? -
also: in GitHub, you can go to "Files changed" -> "Review changes" to submit a review of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good to me 👍
@intelliot thanks, yes I was looking for a dockerfile to make it easy to install a rippled instance. I have also submitted the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I will try to catch up with this by the end of next week. |
@ckeshava as this PR has been updated since your last review, could you re-review? |
I think the commits need to be rebased to the latest develop branch |
requested changes have been resolved
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
High Level Overview of Change
Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
Context of Change
It was a bit difficult to find the helpful instructions in environment.md.
Type of Change