-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to self-hosted runners for macOS #4511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing his.
Just for grins I pushed this branch to my personal GitHub. It tried to run MacOS tests. For over 30 minutes the display showed this:
Requested labels: self-hosted, macOS
Job defined at: scottschurr/rippled/.github/workflows/macos.yml@refs/heads/john-macos
Waiting for a runner to pick up this job...
After that I canceled the workflow. I'm assuming that's expected behavior. The self-hosted runners will only pickup from develop or some such.
Not complaining. Just making sure that's expected behavior.
It's expected behavior if you have not yet added a self-hosted runner to your personal fork. See these instructions for Ripple employees. If you create a PR, the workflow will be picked up by the self-hosted runners attached to the upstream project. XRPLF/rippled already has some, as does my fork. |
Those instructions are not visible for me. Those should probably be documented elsewhere. |
I can view the instructions, but I guess they are private to certain users; I don't have permission to modify the repo's visibility. @shichengripple001 owns the repo. @shichengripple001 or @legleux - can you grant Read access to members of the Ripple github org? |
No description provided.