fix node size estimation #4536
fix node size estimation #4536
Conversation
nbougalis
added
Passed
|
This should be included in the next release, as it fixes a bug. |
|
@manojsdoshi to confirm whether this is ok to include in 1.11 Standard procedure is to get 2 approvals, unless the PR is obviously trivial (and in that case, it needs the |
|
Perhaps @sophiax851 or @ChronusZ can take a look? |
|
This is a bug fix that impacts servers and, imo, is pretty trivial. Maybe @HowardHinnant can take a quick look? |
|
QA confirmed this is ok to include in 1.11 (if approved by code review) |
There was a problem hiding this comment.
Looks good to me.
Disclaimer: Part of this change is on a Linux-only branch which I'm not able to test. However I know @nbougalis is using Linux and he's approved, so I think we're covered.
|
Note: This was an older bug (i.e. not a bug introduced in 1.11 nor in an RC - release candidate). It's okay this time, but in the future, QA would like to avoid making non-critical (non-blocker) changes within 2 weeks of a release. |
Fix a bug in the `NODE_SIZE` auto-detection feature in `Config.cpp`. Specifically, this patch corrects the calculation for the total amount of RAM available, which was previously returned in bytes, but is now being returned in units of the system's memory unit. Additionally, the patch adjusts the node size based on the number of available hardware threads of execution.
Fix a bug in the `NODE_SIZE` auto-detection feature in `Config.cpp`. Specifically, this patch corrects the calculation for the total amount of RAM available, which was previously returned in bytes, but is now being returned in units of the system's memory unit. Additionally, the patch adjusts the node size based on the number of available hardware threads of execution.
Fix a bug in the `NODE_SIZE` auto-detection feature in `Config.cpp`. Specifically, this patch corrects the calculation for the total amount of RAM available, which was previously returned in bytes, but is now being returned in units of the system's memory unit. Additionally, the patch adjusts the node size based on the number of available hardware threads of execution.
High Level Overview of Change
This patch fixes a bug in the NODE_SIZE autodetection feature in the Config.cpp file. Specifically, this patch corrects the calculation for the total amount of RAM available, which was previously returned in bytes, but is now being returned in units of the system's memory unit. Additionally, the patch adjusts the node size based on the number of available hardware threads of execution.
Context of Change
Type of Change