Trivial: add comments for NFToken-related invariants #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisDawson
approved these changes
Jun 5, 2023
|
Thanks for the comments @DennisDawson. I believe I've addressed them. Let me know what you think. |
ledhed2222
reviewed
Jun 7, 2023
ledhed2222
approved these changes
Jun 7, 2023
|
Added the allowed numbers of |
DennisDawson
approved these changes
Jun 8, 2023
intelliot
approved these changes
Jun 9, 2023
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Jul 10, 2023
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The docs folks rely on comments describing the invariants. Two invariants had been added without comments. This pull request adds the comments so they will be available for docs folks into the future.
Context of Change
Docs folks were updating the invariants documentation and noted some information was missing. This adds the information they need.
Type of Change