Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate grpc port info in GRPCServer ctor #4560

Closed
wants to merge 95 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
8e122c5
Fix #4015, #4557: Do not validate GRPC IP/Port/Protocol information i…
ckeshava Jun 7, 2023
8e4c068
Introduce a constant for port_grpc configuration section
ckeshava Jun 9, 2023
1c4a100
Replace all usages of "port_grpc" raw string with a constant
ckeshava Jun 9, 2023
64145d5
Created macros for "port_ws", "port_rpc" and "port_peer" for unit tes…
ckeshava Jun 12, 2023
2614b49
rename PORT_GRPC macro into SECTION_PORT_GRPC to adhere to the convec…
ckeshava Aug 25, 2023
6cbebf4
fix #4569: clang warning about deprecated sprintf usage.
ckeshava Jun 12, 2023
8a86400
Trivial: add comments for NFToken-related invariants (#4558)
scottschurr Jun 9, 2023
bb04666
fix node size estimation (#4536)
dangell7 Jun 9, 2023
e7a4883
fix: remove redundant moves (#4565)
ckeshava Jun 10, 2023
2e9c6ef
Set version to 1.11.0-rc3
intelliot Jun 9, 2023
d9df6cc
Set version to 1.11.0
intelliot Jun 20, 2023
5e27424
Enable the Beta RPC API (v2) for all unit tests: (#4573)
ximinez Jun 21, 2023
c15be03
`fixReducedOffersV1`: prevent offers from blocking order books: (#4512)
scottschurr Jun 23, 2023
a185d98
Add RPC/WS ports to server_info (#4427)
drlongle Jun 23, 2023
2e7d70d
ci: use Artifactory remote in nix workflow (#4556)
thejohnfreeman Jun 23, 2023
2225284
refactor: remove TypedField's move constructor (#4567)
HowardHinnant Jun 26, 2023
7623912
XLS-39 Clawback: (#4553)
shawnxie999 Jun 26, 2023
a5a866c
Set version to 1.12.0-b1
intelliot Jun 26, 2023
1e30936
refactor: replace hand-rolled lexicalCast (#4473)
dangell7 Jun 27, 2023
7257583
Fix package definition for Conan (#4485)
thejohnfreeman Jun 27, 2023
301e27c
fix: remove deprecated fields in `ledger` method (#4244)
ckeshava Jun 28, 2023
428c0e2
refactor: rename ServerHandlerImp to ServerHandler (#4516)
scottschurr Jun 28, 2023
384b5ab
Fix build references to deleted ServerHandlerImp: (#4592)
ximinez Jun 28, 2023
179ab0a
APIv2: add error messages for account_tx (#4571)
PeterChen13579 Jun 29, 2023
e14d9c6
fix: Update Handler::Condition enum values #3417 (#4239)
ckeshava Jun 29, 2023
c18ed1c
ci: cancel overridden workflows (#4597)
thejohnfreeman Jun 29, 2023
035930a
fix: deb package build (#4591)
legleux Jun 30, 2023
e04d6f1
APIv2(account_info): handle invalid "signer_lists" value (#4585)
PeterChen13579 Jun 30, 2023
f6ca3f4
chore: update checkout action version to v3: (#4598)
ximinez Jul 1, 2023
f189ffe
add clang-format pre-commit hook (#4599)
mvadari Jul 1, 2023
da1175f
build: add binary hardening compile and link flags (#4603)
thejohnfreeman Jul 3, 2023
2ce1116
fix: add allowClawback flag for `account_info` (#4590)
shawnxie999 Jul 5, 2023
c013763
refactor: change the return type of mulDiv to std::optional (#4243)
ckeshava Jul 6, 2023
0fa1b97
APIv2(ledger_entry): return "invalidParams" when fields missing (#4552)
arihantkothari Jul 6, 2023
3e1cd0d
docs(CONTRIBUTING): push beta releases to `release` (#4589)
intelliot Jul 7, 2023
74181af
Adapt to change in Conan recipe for NuDB (#4615)
thejohnfreeman Jul 11, 2023
ecd1ed0
Introduce AMM support (XLS-30d): (#4294)
gregtatcam Jul 12, 2023
327c0c9
Update dependencies (#4595)
thejohnfreeman Jul 13, 2023
56c7fd7
Rename `allowClawback` flag to `allowTrustLineClawback` (#4617)
shawnxie999 Jul 14, 2023
0b4e8fd
BUILD: list steps after dependencies update (#4623)
intelliot Jul 18, 2023
01ff938
Set version to 1.12.0-b2
intelliot Jul 18, 2023
393c9ee
docs: add API Changelog (#4612)
intelliot Jul 19, 2023
45deab1
feat: support Concise Transaction Identifier (CTID) (XLS-37) (#4418)
RichardAH Aug 18, 2023
2b870b2
fix(AMM): prevent orphaned objects, inconsistent ledger state: (#4626)
gregtatcam Jul 17, 2023
c691c3c
refactor: use C++20 function std::popcount (#4389)
a-noni-mousse Jul 2, 2023
2945681
refactor: improve checking of path lengths (#4519)
a-noni-mousse May 7, 2023
49d0fa0
Fix the package recipe for consumers of libxrpl (#4631)
thejohnfreeman Jul 18, 2023
7abb77b
add view updates for account SLEs (#4629)
mvadari Jul 18, 2023
e5200cf
test: add forAllApiVersions helper function (#4611)
arihantkothari Jul 9, 2023
76c2af3
Update Ubuntu build image (#4650)
legleux Aug 12, 2023
b6569a7
refactor: fix typo in FeeUnits.h (#4644)
eltociear Aug 9, 2023
abfaf9a
Asynchronously write batches to NuDB (#4503)
mtrippled Aug 19, 2023
0a4e671
Apply transaction batches in periodic intervals (#4504)
mtrippled Aug 19, 2023
4b65b99
Several changes to improve Consensus stability: (#4505)
mtrippled Aug 19, 2023
5268721
Set version to 1.12-b3
manojsdoshi Aug 18, 2023
a386722
Set version to 1.12.0-rc1
manojsdoshi Aug 21, 2023
a324699
minor: clang-format
ckeshava Sep 1, 2023
76b2b86
Revert "Several changes to improve Consensus stability: (#4505)"
intelliot Aug 29, 2023
0a0e2fc
Revert "Apply transaction batches in periodic intervals (#4504)"
intelliot Aug 30, 2023
d2a8b6e
Revert "Asynchronously write batches to NuDB (#4503)"
intelliot Aug 30, 2023
5713dcf
Set version to 1.12.0-rc3
intelliot Aug 30, 2023
3fa056c
AMMBid: use tecINTERNAL for 'impossible' errors (#4674)
mDuo13 Sep 1, 2023
7a9eb4c
amm_info: fetch by amm account id; add AMM object entry (#4682)
gregtatcam Sep 1, 2023
71bdc72
Set version to 1.12.0-rc4
intelliot Sep 1, 2023
cf103d4
Set version to 1.12.0
manojsdoshi Sep 6, 2023
8f6e7e0
Introduce replacement for getting and setting thread name: (#4312)
HowardHinnant Sep 7, 2023
fc5e499
clang format
ckeshava Sep 7, 2023
42e0ab2
docs(rippled-example.cfg): clarify ssl_cert vs ssl_chain (#4667)
ggprod Sep 7, 2023
c0bbabb
APIv2(ledger_entry): return invalidParams for bad parameters (#4630)
PeterChen13579 Sep 8, 2023
19eb419
refactor: simplify `TxFormats` common fields logic (#4637)
mvadari Sep 8, 2023
a9b83b6
docs: update SECURITY.md (#4338)
intelliot Sep 8, 2023
51a6306
Remove CurrentThreadName.h from RippledCore.cmake (#4697)
HowardHinnant Sep 11, 2023
ea20080
Asynchronously write batches to NuDB. (#4503)
mtrippled Sep 11, 2023
1be5ef2
Apply transaction batches in periodic intervals (#4504)
mtrippled Sep 11, 2023
8a400c0
Several changes to improve Consensus stability: (#4505)
mtrippled Sep 11, 2023
23d0991
APIv2(account_tx, noripple_check): return error on invalid input (#4620)
PeterChen13579 Sep 13, 2023
af1ea4d
`XChainBridge`: Introduce sidechain support (XLS-38): (#4292)
seelabs Sep 14, 2023
5edadfc
Revert ThreadName due to problems on Windows (#4702)
HowardHinnant Sep 14, 2023
661e655
Match unit tests on start of test name (#4634)
ximinez Sep 14, 2023
9da0463
clang format -- from patch file and comparison with upstream/develop
ckeshava Sep 15, 2023
659fbed
Fix Windows build by removing two unused declarations (#4708)
seelabs Sep 15, 2023
3ade944
clang-format for JSONRPC_test
ckeshava Sep 22, 2023
ddcd062
Change `XChainBridge` amendment to `Supported::yes` (#4709)
seelabs Sep 15, 2023
7582205
Revert CMake changes (#4707)
legleux Sep 15, 2023
e5f6221
Set version to 2.0.0-b1
intelliot Sep 14, 2023
016b0a3
docs(BUILD): make it easier to find environment.md (#4507)
intelliot Sep 16, 2023
cac96b1
fix: remove unused variable causing clang 14 build errors (#4672)
ximinez Sep 18, 2023
4e75aab
docs: fix comment for LedgerHistory::fixIndex return value (#4574)
ckeshava Sep 18, 2023
de9540c
Update secp256k1 to 0.3.2 (#4653)
thejohnfreeman Sep 18, 2023
279d696
docs(RELEASENOTES): update 1.12.0 notes to match dev blog (#4691)
intelliot Sep 19, 2023
ba03e5d
docs(API-CHANGELOG): api_version 2 is expected with 2.0 (#4633)
intelliot Sep 19, 2023
02a53e5
docs(overlay): add URL of blog post and clarify wording (#4635)
ckeshava Sep 19, 2023
c7d0ee4
build: use Boost 1.82 and link Boost.Json (#4632)
thejohnfreeman Sep 21, 2023
05ac9c9
APIv2(gateway_balances, channel_authorize): update errors (#4618)
PeterChen13579 Sep 21, 2023
ae0c816
Fix typo in BUILD.md (#4718)
Sep 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ripple/rpc/impl/ServerHandlerImp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1148,6 +1148,12 @@ parse_Ports(Config const& config, std::ostream& log)
log << "Missing section: [" << name << "]";
Throw<std::exception>();
}

// grpc ports are parsed by GRPCServer class. Do not validate
// grpc port information in this file.
if (name == "port_grpc")
Copy link
Contributor

@cjcobb23 cjcobb23 Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"port_grpc" should probably be defined as a constant somewhere

continue;

ParsedPort parsed = common;
parsed.name = name;
parse_Port(parsed, config[name], log);
Expand Down