-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate grpc port info in GRPCServer ctor #4560
Closed
Closed
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
8e122c5
Fix #4015, #4557: Do not validate GRPC IP/Port/Protocol information i…
ckeshava 8e4c068
Introduce a constant for port_grpc configuration section
ckeshava 1c4a100
Replace all usages of "port_grpc" raw string with a constant
ckeshava 64145d5
Created macros for "port_ws", "port_rpc" and "port_peer" for unit tes…
ckeshava 2614b49
rename PORT_GRPC macro into SECTION_PORT_GRPC to adhere to the convec…
ckeshava 6cbebf4
fix #4569: clang warning about deprecated sprintf usage.
ckeshava 8a86400
Trivial: add comments for NFToken-related invariants (#4558)
scottschurr bb04666
fix node size estimation (#4536)
dangell7 e7a4883
fix: remove redundant moves (#4565)
ckeshava 2e9c6ef
Set version to 1.11.0-rc3
intelliot d9df6cc
Set version to 1.11.0
intelliot 5e27424
Enable the Beta RPC API (v2) for all unit tests: (#4573)
ximinez c15be03
`fixReducedOffersV1`: prevent offers from blocking order books: (#4512)
scottschurr a185d98
Add RPC/WS ports to server_info (#4427)
drlongle 2e7d70d
ci: use Artifactory remote in nix workflow (#4556)
thejohnfreeman 2225284
refactor: remove TypedField's move constructor (#4567)
HowardHinnant 7623912
XLS-39 Clawback: (#4553)
shawnxie999 a5a866c
Set version to 1.12.0-b1
intelliot 1e30936
refactor: replace hand-rolled lexicalCast (#4473)
dangell7 7257583
Fix package definition for Conan (#4485)
thejohnfreeman 301e27c
fix: remove deprecated fields in `ledger` method (#4244)
ckeshava 428c0e2
refactor: rename ServerHandlerImp to ServerHandler (#4516)
scottschurr 384b5ab
Fix build references to deleted ServerHandlerImp: (#4592)
ximinez 179ab0a
APIv2: add error messages for account_tx (#4571)
PeterChen13579 e14d9c6
fix: Update Handler::Condition enum values #3417 (#4239)
ckeshava c18ed1c
ci: cancel overridden workflows (#4597)
thejohnfreeman 035930a
fix: deb package build (#4591)
legleux e04d6f1
APIv2(account_info): handle invalid "signer_lists" value (#4585)
PeterChen13579 f6ca3f4
chore: update checkout action version to v3: (#4598)
ximinez f189ffe
add clang-format pre-commit hook (#4599)
mvadari da1175f
build: add binary hardening compile and link flags (#4603)
thejohnfreeman 2ce1116
fix: add allowClawback flag for `account_info` (#4590)
shawnxie999 c013763
refactor: change the return type of mulDiv to std::optional (#4243)
ckeshava 0fa1b97
APIv2(ledger_entry): return "invalidParams" when fields missing (#4552)
arihantkothari 3e1cd0d
docs(CONTRIBUTING): push beta releases to `release` (#4589)
intelliot 74181af
Adapt to change in Conan recipe for NuDB (#4615)
thejohnfreeman ecd1ed0
Introduce AMM support (XLS-30d): (#4294)
gregtatcam 327c0c9
Update dependencies (#4595)
thejohnfreeman 56c7fd7
Rename `allowClawback` flag to `allowTrustLineClawback` (#4617)
shawnxie999 0b4e8fd
BUILD: list steps after dependencies update (#4623)
intelliot 01ff938
Set version to 1.12.0-b2
intelliot 393c9ee
docs: add API Changelog (#4612)
intelliot 45deab1
feat: support Concise Transaction Identifier (CTID) (XLS-37) (#4418)
RichardAH 2b870b2
fix(AMM): prevent orphaned objects, inconsistent ledger state: (#4626)
gregtatcam c691c3c
refactor: use C++20 function std::popcount (#4389)
a-noni-mousse 2945681
refactor: improve checking of path lengths (#4519)
a-noni-mousse 49d0fa0
Fix the package recipe for consumers of libxrpl (#4631)
thejohnfreeman 7abb77b
add view updates for account SLEs (#4629)
mvadari e5200cf
test: add forAllApiVersions helper function (#4611)
arihantkothari 76c2af3
Update Ubuntu build image (#4650)
legleux b6569a7
refactor: fix typo in FeeUnits.h (#4644)
eltociear abfaf9a
Asynchronously write batches to NuDB (#4503)
mtrippled 0a4e671
Apply transaction batches in periodic intervals (#4504)
mtrippled 4b65b99
Several changes to improve Consensus stability: (#4505)
mtrippled 5268721
Set version to 1.12-b3
manojsdoshi a386722
Set version to 1.12.0-rc1
manojsdoshi a324699
minor: clang-format
ckeshava 76b2b86
Revert "Several changes to improve Consensus stability: (#4505)"
intelliot 0a0e2fc
Revert "Apply transaction batches in periodic intervals (#4504)"
intelliot d2a8b6e
Revert "Asynchronously write batches to NuDB (#4503)"
intelliot 5713dcf
Set version to 1.12.0-rc3
intelliot 3fa056c
AMMBid: use tecINTERNAL for 'impossible' errors (#4674)
mDuo13 7a9eb4c
amm_info: fetch by amm account id; add AMM object entry (#4682)
gregtatcam 71bdc72
Set version to 1.12.0-rc4
intelliot cf103d4
Set version to 1.12.0
manojsdoshi 8f6e7e0
Introduce replacement for getting and setting thread name: (#4312)
HowardHinnant fc5e499
clang format
ckeshava 42e0ab2
docs(rippled-example.cfg): clarify ssl_cert vs ssl_chain (#4667)
ggprod c0bbabb
APIv2(ledger_entry): return invalidParams for bad parameters (#4630)
PeterChen13579 19eb419
refactor: simplify `TxFormats` common fields logic (#4637)
mvadari a9b83b6
docs: update SECURITY.md (#4338)
intelliot 51a6306
Remove CurrentThreadName.h from RippledCore.cmake (#4697)
HowardHinnant ea20080
Asynchronously write batches to NuDB. (#4503)
mtrippled 1be5ef2
Apply transaction batches in periodic intervals (#4504)
mtrippled 8a400c0
Several changes to improve Consensus stability: (#4505)
mtrippled 23d0991
APIv2(account_tx, noripple_check): return error on invalid input (#4620)
PeterChen13579 af1ea4d
`XChainBridge`: Introduce sidechain support (XLS-38): (#4292)
seelabs 5edadfc
Revert ThreadName due to problems on Windows (#4702)
HowardHinnant 661e655
Match unit tests on start of test name (#4634)
ximinez 9da0463
clang format -- from patch file and comparison with upstream/develop
ckeshava 659fbed
Fix Windows build by removing two unused declarations (#4708)
seelabs 3ade944
clang-format for JSONRPC_test
ckeshava ddcd062
Change `XChainBridge` amendment to `Supported::yes` (#4709)
seelabs 7582205
Revert CMake changes (#4707)
legleux e5f6221
Set version to 2.0.0-b1
intelliot 016b0a3
docs(BUILD): make it easier to find environment.md (#4507)
intelliot cac96b1
fix: remove unused variable causing clang 14 build errors (#4672)
ximinez 4e75aab
docs: fix comment for LedgerHistory::fixIndex return value (#4574)
ckeshava de9540c
Update secp256k1 to 0.3.2 (#4653)
thejohnfreeman 279d696
docs(RELEASENOTES): update 1.12.0 notes to match dev blog (#4691)
intelliot ba03e5d
docs(API-CHANGELOG): api_version 2 is expected with 2.0 (#4633)
intelliot 02a53e5
docs(overlay): add URL of blog post and clarify wording (#4635)
ckeshava c7d0ee4
build: use Boost 1.82 and link Boost.Json (#4632)
thejohnfreeman 05ac9c9
APIv2(gateway_balances, channel_authorize): update errors (#4618)
PeterChen13579 ae0c816
Fix typo in BUILD.md (#4718)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"port_grpc"
should probably be defined as a constant somewhere