fix: remove redundant moves #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HowardHinnant can you please review this? |
intelliot
requested review from
seelabs and
HowardHinnant
and removed request for
drlongle
ckeshava
force-pushed
the
moveOptimizationPatch
branch
from
042955c to
f3a5731
Compare
|
Suggested commit message: |
- Resolve gcc compiler warning:
AccountObjects.cpp:182:47: warning: redundant move in initialization [-Wredundant-move]
- The std::move() operation on trivially copyable types may generate a
compile warning in newer versions of gcc.
- Remove extraneous header (unused imports) from a unit test file.
ckeshava
force-pushed
the
moveOptimizationPatch
branch
from
f3a5731 to
1ed53d8
Compare
HowardHinnant
approved these changes
Jun 9, 2023
This reverts commit ee01651.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this pull request
Jul 10, 2023
- Resolve gcc compiler warning:
AccountObjects.cpp:182:47: warning: redundant move in initialization [-Wredundant-move]
- The std::move() operation on trivially copyable types may generate a
compile warning in newer versions of gcc.
- Remove extraneous header (unused imports) from a unit test file.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
- Resolve gcc compiler warning:
AccountObjects.cpp:182:47: warning: redundant move in initialization [-Wredundant-move]
- The std::move() operation on trivially copyable types may generate a
compile warning in newer versions of gcc.
- Remove extraneous header (unused imports) from a unit test file.
ckeshava
added a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
- Resolve gcc compiler warning:
AccountObjects.cpp:182:47: warning: redundant move in initialization [-Wredundant-move]
- The std::move() operation on trivially copyable types may generate a
compile warning in newer versions of gcc.
- Remove extraneous header (unused imports) from a unit test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR removes redundant use of
std::movein the codebase. Since the types are trivially-copyable, the compiler will copy it despite the usage ofstd::move.I've also removed an unused import in one of the unit test files, I noticed it while working on something else.
As a sidenote, do you guys know of any tools to clean up unused imports? There seem to be many in the rippled codebase.
@seelabs thanks for pointing out the compiler warnings. Can you please review this PR?
Context of Change
Type of Change