-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable api_version 2 #4568
Enable api_version 2 #4568
Conversation
Discussed today and decided to hold this for 1.13 or later. |
Sorry, I missed this comment. Okay! Thanks for the update @intelliot ! |
Leaving this comment here (this is from a while back): Changing Let me be clear here: this PR will still pass all the tests because I added api_version 1 in the test. But the underlying problem STILL exists. |
update: @pwang200 will take a look at this and potentially open a new PR |
Closing this PR since #4785 is now open. |
The command line API still uses `apiMaximumSupportedVersion`. The unit test RPCs use `apiMinimumSupportedVersion` if unspecified. Context: - XRPLF#4568 - XRPLF#4552
High Level Overview of Change
Enabling
api_version
2 by bumping upapiMaximumSupportedVersion
to 2 and fixingAccountInfo
tests that were failing as a consequence.Context of Change
Changing error code leads to breaking changes for error handling in applications relying on those error codes. Hence, all these changes should be upgraded to the next
api_version
, so that existing users get the existing behaviour, and users who request a higherapi_version
get the new behaviour.More context: #4552
Type of Change