Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment about return value of LedgerHistory::fixIndex #4574

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update comment about return value of LedgerHistory::fixIndex #4574

merged 1 commit into from
Sep 18, 2023

Conversation

ckeshava
Copy link
Collaborator

This PR addresses #4572.

I believe the existing comment belies it's true purpose.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@intelliot intelliot added Documentation README changes, code comments, etc. Trivial labels Sep 3, 2023
@intelliot intelliot added this to the 1.13 milestone Sep 3, 2023
@intelliot intelliot merged commit e86181c into XRPLF:develop Sep 18, 2023
@aGoodOne
Copy link

maven was the culprit

ckeshava added a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
@ckeshava
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
4e75aab 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
ckeshava added a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
@ckeshava
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
2995d94 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@ckeshava @sophiax851
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
0f453ce 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

Assignees
No one assigned
Labels
Documentation README changes, code comments, etc. Trivial
Projects
Core Ledger
Archived in project
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ckeshava @aGoodOne @thejohnfreeman @intelliot