Fix deb package build #4591
Merged
Fix deb package build #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --install-folder bld/rippled-reporting \ | ||
| --build missing \ | ||
| --build boost \ | ||
| --build sqlite3 \ | ||
| --build libuv \ | ||
| --settings build_type=Release \ | ||
| --settings compiler.cppstd=17 \ |
There was a problem hiding this comment.
We can't build non-reporting mode without C++20, and we can't build reporting mode with C++20? Is that right?
There was a problem hiding this comment.
It seems to be the case. IIRC, there was an issue building Cassandra.
There was a problem hiding this comment.
Yeah, that's the issue I'm having:
C++20 changes std::memory_order from an
enumto anenum class. Datastax supplies a C++ driver for Cassandra, a dependency of reporting mode. it defines anenum MemoryOrderwhose values are copied fromstd::memory_order, but using values from anenum classis not allowed, causing a compile error: https://godbolt.org/z/dG943nvT7
thejohnfreeman
approved these changes
Jun 27, 2023
intelliot
requested review from
godexsoft and
seelabs
and removed request for
intelliot
legleux
force-pushed
the
fix-deb-pkg-build
branch
from
b1e5fc3 to
3f91982
Compare
rename debug packages ddeb --> deb for Artifactory bug
legleux
force-pushed
the
fix-deb-pkg-build
branch
from
3f91982 to
fba6e08
Compare
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Jul 10, 2023
The debug packages were named with the extension ".ddeb", but due to a
bug in Artifactory, they need to have the ".deb" extension. Debug symbol
packages with ".ddeb" extensions are not indexed, and thus are not
visible in apt clients.
* Fix the issue by renaming the debug packages in the build script.
* Use GCC-11 and update GCC Conan profile.
* This software requires GCC 11 and C++20. However, reporting mode is
built with C++17.
This is a quick band-aid to fix the build. Later, it will be better to
remove this package-building code.
For context, a Debian (deb) package contains bundled software and
resources necessary for installing and managing software on a
Debian-based system, including Ubuntu and derivatives.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
The debug packages were named with the extension ".ddeb", but due to a
bug in Artifactory, they need to have the ".deb" extension. Debug symbol
packages with ".ddeb" extensions are not indexed, and thus are not
visible in apt clients.
* Fix the issue by renaming the debug packages in the build script.
* Use GCC-11 and update GCC Conan profile.
* This software requires GCC 11 and C++20. However, reporting mode is
built with C++17.
This is a quick band-aid to fix the build. Later, it will be better to
remove this package-building code.
For context, a Debian (deb) package contains bundled software and
resources necessary for installing and managing software on a
Debian-based system, including Ubuntu and derivatives.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
The debug packages were named with the extension ".ddeb", but due to a
bug in Artifactory, they need to have the ".deb" extension. Debug symbol
packages with ".ddeb" extensions are not indexed, and thus are not
visible in apt clients.
* Fix the issue by renaming the debug packages in the build script.
* Use GCC-11 and update GCC Conan profile.
* This software requires GCC 11 and C++20. However, reporting mode is
built with C++17.
This is a quick band-aid to fix the build. Later, it will be better to
remove this package-building code.
For context, a Debian (deb) package contains bundled software and
resources necessary for installing and managing software on a
Debian-based system, including Ubuntu and derivatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Use GCC-11 and update GCC Conan profile
Context of Change
This is a quick band aid to get this build fixed.
A goal of Q3 is to remove all this package building code.
Also renames debug packages
ddeb-->debto account for an Artifactory bug where the debug symbol packages with.ddebextensions are not indexed and thus aren't visible in apt clients.Type of Change