Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Windows CI build with Artifactory support #4596

Merged
merged 37 commits into from
Oct 9, 2023
Merged

Reenable Windows CI build with Artifactory support #4596

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ab52f3c
ci: use Artifactory remote in windows workflow
ximinez Jun 23, 2023
3df07fb
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jun 29, 2023
f31ebff
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jun 29, 2023
e0a84e0
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jun 30, 2023
10f25ff
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 5, 2023
e88ca37
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 6, 2023
1b5e089
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 6, 2023
9c0882f
[FOLD] Run on self-hosted runner
ximinez Jul 7, 2023
069aebb
fixup! [FOLD] Run on self-hosted runner
ximinez Jul 7, 2023
ab26e5c
fixup! fixup! [FOLD] Run on self-hosted runner
ximinez Jul 7, 2023
106596b
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 12, 2023
b42edc1
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 14, 2023
5cfa42c
Merge remote-tracking branch 'upstream/develop' into action
ximinez Jul 20, 2023
5d661f5
Merge remote-tracking branch 'upstream/develop' into action
ximinez Aug 23, 2023
f568ac0
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 1, 2023
f01002f
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 11, 2023
9c15e2a
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 11, 2023
77a8f2c
Revert "fixup! fixup! [FOLD] Run on self-hosted runner"
ximinez Sep 14, 2023
de2df5d
Revert "fixup! [FOLD] Run on self-hosted runner"
ximinez Sep 14, 2023
a35dd82
Revert "[FOLD] Run on self-hosted runner"
ximinez Sep 14, 2023
efd32a6
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 15, 2023
0fecaf7
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 18, 2023
4cd85a6
Try using one unit test job?
ximinez Sep 18, 2023
43690b3
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 18, 2023
2f3ddde
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 28, 2023
222c7e4
[FOLD] Address review feedback from @thejohnfreeman:
ximinez Sep 28, 2023
715aeea
fixup! [FOLD] Address review feedback from @thejohnfreeman:
ximinez Sep 28, 2023
1641cc6
fixup! fixup! [FOLD] Address review feedback from @thejohnfreeman:
ximinez Sep 28, 2023
f875a86
[FOLD] Further feedback from @thejohnfreeman:
ximinez Sep 28, 2023
63c6717
Merge remote-tracking branch 'upstream/develop' into action
ximinez Sep 28, 2023
e308801
Merge remote-tracking branch 'upstream/develop' into action
ximinez Oct 2, 2023
8f1c1e4
[FOLD] Improve remote setup step
ximinez Oct 2, 2023
15f1f0c
fixup! [FOLD] Improve remote setup step
ximinez Oct 2, 2023
5778a34
Merge remote-tracking branch 'upstream/develop' into action
ximinez Oct 3, 2023
7fdd63c
Merge remote-tracking branch 'upstream/develop' into action
ximinez Oct 5, 2023
c3bce68
Merge remote-tracking branch 'upstream/develop' into action
ximinez Oct 6, 2023
5f3a938
Merge remote-tracking branch 'upstream/develop' into action
ximinez Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ jobs:
conan profile update settings.compiler.runtime=MT${{ matrix.configuration == 'Debug' && 'd' || '' }} default
# Do not quote the URL. An empty string will be accepted (with
# a non-fatal warning), but a missing argument will not.
conan remote add ripple ${{ env.CONAN_URL }} --insert 0
conan remote add ripple ${{ env.CONAN_URL }} --insert 0 || \
conan remote list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hosted runner seems to be keeping some state between runs, which cause errors when the commands are run again. This was a workaround. Here's an example from my own repo: https://github.com/ximinez/rippled/actions/runs/5490473061/jobs/10005957758#step:8:14

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because the runner does not create a fresh environment for each job? I think we should consider this a blocker.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what it looks like.

- name: try to authenticate to ripple Conan remote
shell: bash
id: remote
Expand Down