Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel overridden workflows #4597

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Cancel overridden workflows #4597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/doxygen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
branches:
- develop
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
job:
Expand All @@ -18,7 +21,7 @@ jobs:
echo ${PATH} | tr ':' '\n'
cmake --version
doxygen --version
env
env | sort
- name: build
run: |
mkdir build
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: macos
on: [push, pull_request]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:

Expand Down Expand Up @@ -29,7 +32,7 @@ jobs:
python --version
conan --version
cmake --version
env
env | sort
- name: build
uses: ./.github/actions/build
with:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/nix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: nix
on: [push, pull_request]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

# This workflow has two job matrixes.
# They can be considered phases because the second matrix ("test")
Expand Down Expand Up @@ -57,7 +60,7 @@ jobs:
echo ${PATH} | tr ':' '\n'
conan --version
cmake --version
env
env | sort
- name: configure Conan
env:
CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/conan-non-prod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the dns mapping changes in the future, won't we be in trouble because we have hard-coded the IP address?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no domain name for this address. No mapping to change.

The risk is that the public IP address for this machine changes. We have already discussed, internally, adding a domain name for this machine. It will be an improvement, but it is not necessary.

Lastly, the IP address is already hard-coded in the workflows. It is not part of this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, ok

Expand Down Expand Up @@ -139,7 +142,7 @@ jobs:
echo ${PATH} | tr ':' '\n'
conan --version
cmake --version
env
env | sort
ls ~/.conan
- name: checkout
uses: actions/checkout@v3
Expand Down