Adapt to change in Conan recipe for NuDB #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejohnfreeman
requested review from
legleux,
gregtatcam,
ximinez and
scottschurr
|
QA build passed on ubuntu & MAC (intel chip). |
gregtatcam
reviewed
Jul 11, 2023
There was a problem hiding this comment.
It didn't work. Tried on OSX. Deleted ~/.conan/data then ran conan install ... and then cmake -D.... cmake failed:
CMake Error at CMakeLists.txt:99 (target_link_libraries):
The link interface of target "ripple_libs" contains:
nudb::core
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
|
This branch is working for me on macOS. Congrats! MacOS: Ventura 13.4.1 |
@scottschurr , have you removed |
|
@gregtatcam, Yup. Removed ~/.conan/data and my build directory before starting the process. |
Hm, ok. I must have missed something... Will give it another try. |
thejohnfreeman
added
the
Passed
seelabs
pushed a commit
to seelabs/rippled
that referenced
this pull request
Jul 11, 2023
The recipe was updated a few days ago and the exported library target was renamed.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Aug 3, 2023
The recipe was updated a few days ago and the exported library target was renamed.
scottschurr
pushed a commit
to scottschurr/rippled
that referenced
this pull request
Aug 3, 2023
The recipe was updated a few days ago and the exported library target was renamed.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
The recipe was updated a few days ago and the exported library target was renamed.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
The recipe was updated a few days ago and the exported library target was renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.