Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(overlay): add URL of blog post and clarify wording #4635

Merged
merged 6 commits into from
Sep 19, 2023
Merged

docs(overlay): add URL of blog post and clarify wording #4635

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8142ba
rectify the wording of the docs: Use of private key for signing the f…
ckeshava Jul 27, 2023
c31aca7
include blog post explaining the reasons for squelch, reduce_relay ch…
ckeshava Jul 27, 2023
aa173df
Update README.md
intelliot Jul 27, 2023
a7fc73f
clang-format
intelliot Jul 27, 2023
b6de402
Merge branch 'develop' into docsUpdate
intelliot Aug 27, 2023
9e49467
Merge branch 'develop' into docsUpdate
intelliot Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/ripple/overlay/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,11 @@ messages for the local and remote endpoints, and combine them to generate a uniq
"fingerprint". By design, this fingerprint should be the same for both SSL/TLS
endpoints.

That fingerprint, which is never shared over the wire (since each endpoint will
calculate it independently), is then signed by each server using its public
intelliot marked this conversation as resolved.
Show resolved Hide resolved
**`secp256k1`** node identity and the signature is transferred over the SSL/TLS
encrypted link during the protocol handshake phase.
That fingerprint is calculated by each endpoint independently, so the
fingerprint is never transmitted over the network. Each server then utilizes its
private key to sign the fingerprint. This is the same keypair that determines
the server's public `secp256k1` node identity. The signature is transferred over
the secure SSL/TLS encrypted link during the protocol's initial handshake phase.

Each side of the link will verify that the provided signature is from the claimed
public key against the session's unique fingerprint. If this signature check fails
Expand Down
3 changes: 3 additions & 0 deletions src/ripple/overlay/ReduceRelayCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@

namespace ripple {

// Blog post explaining the rationale behind reduction of flooding gossip
// protocol: https://xrpl.org/blog/2021/message-routing-optimizations-pt-1-proposal-validation-relaying.html
intelliot marked this conversation as resolved.
Show resolved Hide resolved

namespace reduce_relay {

// Peer's squelch is limited in time to
Expand Down