Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] fix typo in FeeUnits.h #4644

Closed
wants to merge 2 commits into from
Closed

[TRIVIAL] fix typo in FeeUnits.h #4644

wants to merge 2 commits into from

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Aug 9, 2023 •
edited by ximinez
Loading

High Level Overview of Change

Context of Change

covert -> convert

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@ximinez ximinez changed the title refactor: fix typo in FeeUnits.h [TRIVIAL] fix typo in FeeUnits.h Aug 9, 2023
@ximinez
Copy link
Collaborator

ximinez commented Aug 9, 2023

Comments are arguably documentation, so I changed the "Type" in the description. I also changed the title to indicate this is trivial, so it will only require one review.

@intelliot intelliot added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 9, 2023
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
9b8f318 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
cb1d6e5 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
bec84cb 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
93163a9 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
a613889 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
826ffb8 
covert -> convert
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
c984747 
covert -> convert

Signed-off-by: Manoj Doshi <[email protected]>
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
90af2c6 
covert -> convert

Signed-off-by: Manoj Doshi <[email protected]>
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
966507a 
covert -> convert

Signed-off-by: Manoj Doshi <[email protected]>
This was referenced Aug 18, 2023
Closed
Closed
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 19, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
1723110 
covert -> convert

Signed-off-by: Manoj Doshi <[email protected]>
@manojsdoshi manojsdoshi mentioned this pull request Aug 19, 2023
Merged
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 21, 2023
@eltociear @manojsdoshi
refactor: fix typo in FeeUnits.h (XRPLF#4644)
213491d 
covert -> convert
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
@eltociear @ckeshava
refactor: fix typo in FeeUnits.h (XRPLF#4644)
b6569a7 
covert -> convert
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
@eltociear @ckeshava
refactor: fix typo in FeeUnits.h (XRPLF#4644)
022157c 
covert -> convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

@intelliot intelliot intelliot approved these changes

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Core Ledger
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eltociear @ximinez @intelliot @manojsdoshi