[TRIVIAL] Update rippled-example.cfg docs to clarify usage of ssl_cert vs ssl_chain #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
it's strange that the CI tests failed in the previous PR but there is no problem with this PR (the change list is the same) LGTM 👍 |
@ckeshava would it be possible to get a formal approval of the PR so that it could be merged? |
ckeshava
approved these changes
Aug 22, 2023
intelliot
reviewed
Aug 23, 2023
intelliot
changed the title
|
@manojsdoshi I think this would be ok to consider for 1.12.0-rc2 because it is only a trivial comment - no code change |
gregtatcam
pushed a commit
to gregtatcam/rippled
that referenced
this pull request
Sep 8, 2023
Clarify usage of ssl_cert vs ssl_chain
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Clarify usage of ssl_cert vs ssl_chain
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Clarify usage of ssl_cert vs ssl_chain
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Clarify usage of ssl_cert vs ssl_chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Update rippled-example.cfg docs to clarify usage of ssl_cert vs ssl_chain
Context of Change
Type of Change