[TRIVIAL] Remove unused variable flagged by clang 14 #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
approved these changes
Sep 8, 2023
|
This change compiled successfully on my machine (macOS) and all the unit tests passed 👍 |
HowardHinnant
approved these changes
Sep 11, 2023
* upstream/develop: docs: update SECURITY.md (4338) refactor: simplify `TxFormats` common fields logic (4637) APIv2(ledger_entry): return invalidParams for bad parameters (4630) docs(rippled-example.cfg): clarify ssl_cert vs ssl_chain (4667) Introduce replacement for getting and setting thread name: (4312) Set version to 1.12.0 Set version to 1.12.0-rc4 amm_info: fetch by amm account id; add AMM object entry (4682) AMMBid: use tecINTERNAL for 'impossible' errors (4674)
ximinez
force-pushed
the
unused
branch
2 times, most recently
from
99ca52b to
25d67ff
Compare
ximinez
added
the
Passed
|
The two force pushes were me accidentally rebasing after merging, then undoing that. Should be properly merged now. |
* upstream/develop: Several changes to improve Consensus stability: (4505) Apply transaction batches in periodic intervals (4504) Asynchronously write batches to NuDB. (4503) Remove CurrentThreadName.h from RippledCore.cmake (4697)
* upstream/develop: Fix Windows build by removing two unused declarations (4708) Match unit tests on start of test name (4634) Revert ThreadName due to problems on Windows (4702) `XChainBridge`: Introduce sidechain support (XLS-38): (4292) APIv2(account_tx, noripple_check): return error on invalid input (4620)
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Removed the unused variable `none` from `Writer.cpp` which was causing build errors on clang version 14.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Removed the unused variable `none` from `Writer.cpp` which was causing build errors on clang version 14.
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Removed the unused variable `none` from `Writer.cpp` which was causing build errors on clang version 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removes an unused variable that is causing clang 14 builds to error out.
Context of Change
Type of Change
Test Plan
No changes that should affect testing. As long as rippled builds, and existing tests pass, we're good.