Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum compiler requirements in BUILD.md #4700

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Update minimum compiler requirements in BUILD.md #4700

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856401d
Update minimum compiler requirements in BUILD.md
ckeshava Sep 11, 2023
1dc1a22
revert apple-clang requirements to 13.1.6
ckeshava Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BUILD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ The [minimum compiler versions][2] required are:

| Compiler | Version |
|-------------|---------|
| GCC | 10 |
| GCC | 11 |
| Clang | 13 |
| Apple Clang | 13.1.6 |
| Apple Clang | 14.0.3 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using enum is supported in Clang 13. Let's not change that minimum requirement until we know for sure that we need it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. but is there any disadvantage to upgrading directly to 14? since the code has been working with clang 14, I assumed we could upgrade. But I don't have strong opinions about this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for a builder to upgrade. We don't want to tell people they have to upgrade if there is no reason to upgrade. These are minimum required versions.

| MSVC | 19.23 |

We don't recommend Windows for `rippled` production at this time. As of
Expand Down