Revert CMake changes #4707
Merged
Revert CMake changes #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@seelabs confirmed this should be ok) |
intelliot
force-pushed
the
develop-next
branch
2 times, most recently
from
6615e01 to
237b406
Compare
intelliot
approved these changes
Sep 15, 2023
intelliot
pushed a commit
that referenced
this pull request
Sep 15, 2023
This was likely put back when #4292 was rebased.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
This was likely put back when XRPLF#4292 was rebased.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
This was likely put back when XRPLF#4292 was rebased.
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
This was likely put back when XRPLF#4292 was rebased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early return from
RippledRelease.cmakepreventing targets being created during packaging.