Remove two unused functions #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
approved these changes
Sep 14, 2023
scottschurr
approved these changes
Sep 15, 2023
scottschurr
added
the
Passed
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Remove the `verify` and `message` function declarations. The explicit instantiation requests could not be completed because there were no implementations for those two member functions. It is helpful that the Microsoft (MSVC) compiler on Windows appears to be strict when it comes to template instantiation. This resolves the warning: XChainAttestations.h(450): warning C4661: 'bool ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void) const': no suitable definition provided for explicit template instantiation request
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Remove the `verify` and `message` function declarations. The explicit instantiation requests could not be completed because there were no implementations for those two member functions. It is helpful that the Microsoft (MSVC) compiler on Windows appears to be strict when it comes to template instantiation. This resolves the warning: XChainAttestations.h(450): warning C4661: 'bool ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void) const': no suitable definition provided for explicit template instantiation request
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Remove the `verify` and `message` function declarations. The explicit instantiation requests could not be completed because there were no implementations for those two member functions. It is helpful that the Microsoft (MSVC) compiler on Windows appears to be strict when it comes to template instantiation. This resolves the warning: XChainAttestations.h(450): warning C4661: 'bool ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void) const': no suitable definition provided for explicit template instantiation request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.