Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify definition of "network health." #4729

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Clarify definition of "network health." #4729

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73b0ecf
Clarify definition of "network health."
mtrippled Sep 25, 2023
2237f1d
Review fixes.
mtrippled Sep 28, 2023
e7841e7
Further clarify document.
mtrippled Oct 13, 2023
a5e12e0
Remove unnecessary sentence.
mtrippled Oct 13, 2023
8d60850
Review fix, remove isolated sentence.
mtrippled Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/ripple/app/misc/FeeEscalation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,17 @@ lower) fee to get into the same position as a reference transaction.

### Consensus Health

For consensus to be considered healthy, the consensus process must take
less than 5 seconds. This time limit was chosen based on observed past
behavior of the network. Note that this is not necessarily the time between
For consensus to be considered healthy, the peers on the network
should largely remain in sync with one another. It is particularly
important for the validators to remain in sync, because they must
be in sync to participate in consensus. Another factor to consider is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would avoid repeated "in sync" and instead use "... validators to remain in sync in order to participate in consensus."

the duration of the consensus process itself. This generally takes
under 5 seconds on the main network. This is based on historical
observations. However, some factors, such as transactions volumes,
can increase consensus duration. This is because rippled performs
more work as transaction volume increases. Under sufficient load this
tends to increase consensus duration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add "time" here "Under sufficient load this time tends to ...", because we refer to "the time" in the sentence below which is now pushed far from the reference to consensus duration time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duration is more precise, though "time" as used here means duration among other things. So duration is more appropriate here and I changed other instances of "time" to reflect that.

Note that this is not necessarily the time between
ledger closings, as consensus usually starts some amount of time after
a ledger opens.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this sentence be moved up ? It seems disconnected here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the sentence entirely. It's not a useful detail here.


Expand Down