Fix output of remote step in nix workflow #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng binaries into remote internal artifactory
|
This pull request supercedes #4716 @ximinez @thejohnfreeman I have collected all the changes into this PR |
8 tasks
ximinez
approved these changes
Oct 4, 2023
|
@ximinez My apologies, I understand the inconvenience. I'll keep that in mind for the next time. |
No worries. I realized after I wrote the comment that this was the one you couldn't push to anymore, which completely justifies making a copy. In this case. 😁 (Which is why I deleted the comment, too.) |
thejohnfreeman
approved these changes
Oct 6, 2023
|
@ckeshava - from your perspective, please confirm if this PR is ready to merge |
|
@intelliot Yes, it looks good to me |
intelliot
added
the
Passed
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
…#4746) Update the nix CI runner. This commit does not modify any source code files. The unix builds were successful, but the binaries were not uploaded to the internal artifactory. This PR borrows an idea from @ximinez to attempt to fix this issue. After successful authentication, the `outcome` variable contains a string. In the upload step, we are checking if outcome == 'success' as a prerequisite for uploading the binary. This commit updates the contents of the `outcome` variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This pull request updates the nix CI runner. Although the builds are successful, the binaries are not uploaded to the internal artifactory. This PR attempts to fix this issue and I have borrowed the idea from @ximinez
After successful authentication, outcome variable contains a string. In the upload step, we are checking if outcome == success as a prerequisite for uploading the binary.
This PR updates the contents of the outcome variable in the CI.
Example of a breaking Github Actions workflow (thanks to @thejohnfreeman): https://github.com/XRPLF/rippled/actions/runs/6264131645/job/17010134246
Context of Change
Type of Change
This does not modify any of the source code files.
This change as motivated from this slack discussion: https://ripple-enterprise.slack.com/archives/C02GE9NBA/p1695051230548129