Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang warning about deprecated sprintf usage #4747

Merged
merged 2 commits into from
Jan 16, 2024
Merged

clang warning about deprecated sprintf usage #4747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
093c810
fix XRPLF#4569: clang warning about deprecated sprintf usage
ckeshava Oct 4, 2023
b7a5338
Merge branch 'develop' into sprintfClang
intelliot Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/ripple/json/impl/json_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,10 +922,8 @@ Reader::getLocationLineAndColumn(Location location) const
{
int line, column;
getLocationLineAndColumn(location, line, column);
constexpr std::size_t n = 18 + 16 + 16 + 1;
char buffer[n];
snprintf(buffer, n, "Line %d, Column %d", line, column);
return buffer;
return "Line " + std::to_string(line) + ", Column " +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you kept the form of the string formatting similar to the other string formatting in the file.

std::to_string(column);
}

std::string
Expand Down