-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixPreviousTxnID
: add sfPreviousTxnID
/sfPreviousTxnLgrSequence
to all ledger objects
#4751
Conversation
e9c9c47
to
b906549
Compare
sfPreviousTxnID
/sfPreviousTxnLgrSequence
to all ledger objectssfPreviousTxnID
/sfPreviousTxnLgrSequence
to all ledger objects
70592c5
to
375d7a0
Compare
375d7a0
to
2712056
Compare
@Silkjaer @RichardAH @nixer89 @dangell7 this is ready for review now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4751 +/- ##
========================================
Coverage 76.97% 76.97%
========================================
Files 1129 1129
Lines 131914 131959 +45
Branches 39629 39687 +58
========================================
+ Hits 101539 101574 +35
- Misses 24459 24505 +46
+ Partials 5916 5880 -36 ☔ View full report in Codecov by Sentry. |
Proposed commit message:
|
cda8ba2
to
b848766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I can't help myself, I made all the changes from my feedback, except the feature name, in a branch: mvadari/rippled@fix-prev-txn-id...ximinez:rippled:mv/4751-prev-txn-id
Pick and choose as you see fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I'm not sure who to tag to indicate that this is ready to go (maybe @seelabs) - the Mac test failure looks like the known flakiness, not an actual failure. |
I see you proposed a commit message (#4751 (comment)), and I just added the "Passed" label. One of us will merge it soon. |
|
sfPreviousTxnID
/sfPreviousTxnLgrSequence
to all ledger objectsfixPreviousTxnID
: add sfPreviousTxnID
/sfPreviousTxnLgrSequence
to all ledger objects
High Level Overview of Change
This PR adds
sfPreviousTxnID
/sfPreviousTxnLgrSequence
as fields to all ledger objects that don't already have them (exceptLedgerHashes
, because that seems a bit redundant and also those objects aren't modified via transaction).The affected objects are:
DirectoryNode
Amendments
FeeSettings
NegativeUNL
AMM
Context of Change
It makes it a lot easier to go through the history of a ledger object. Related to #4602.
Type of Change
Test Plan
Tests have been added to ensure that everything behaves as-is prior to the amendment and transitions seamlessly when the amendment is activated.