Use unity builds to speed up Windows CI #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejohnfreeman
approved these changes
Oct 21, 2023
Bronek
approved these changes
Oct 23, 2023
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
The unity build speeds up compilation by bundling multiple source files into one larger file. This reduces Windows CI build time by up to 50%. As described in XRPLF#4596, the automatic Windows builds take a very long time. Unity builds are significantly faster - currently about 45 min, much closer to the typical MacOS (35-40 minutes) and nix (~30 minutes) run times. This is intended as a stopgap solution until a more resourced and reliable runner is available. No C++ code was changed. This only affects CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Reduces Windows CI build time by up to 50%.
Context of Change
As described in #4596 , the automatic Windows builds take a very long time. Nearly an hour and a half on the latest
develop.Unity builds, while they do have issues of their own, are significantly faster - about 45 minutes on the most recent run from this branch, much closer to the typical MacOS (35-40 minutes) and
nix(~30 minutes) run times.I think this would make a good stopgap solution until a more resourced and reliable runner is available.
Type of Change
Test Plan
No C++ code was changed. This only affects CI, so there is nothing to test.
Future Tasks
As mentioned in #4596, future tasks include making this job run on heavy Windows runners, so it doesn't take so dang long.