Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the mold linker #4807

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Support for the mold linker #4807

merged 1 commit into from
Nov 13, 2023

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Nov 6, 2023

This adds support for the mold linker on linux. On my system this significantly improves link time (from about 18 seconds to about 1 second).

@sublimator
Copy link
Contributor

sublimator commented Nov 7, 2023 via email

@sublimator
Copy link
Contributor

sublimator commented Nov 7, 2023 via email

@Bronek
Copy link
Collaborator

Bronek commented Nov 7, 2023

I tested this under Ubuntu 22.04 container - in this environment gold is always installed because it is included in binutils , and mold is an extra package, so we can have both, but we cannot have mold alone without gold. With the last commit "Use first non-default linker" it all works and the link time with mold is so fast, I can barely spot it (not kidding!)

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works !

@manojsdoshi manojsdoshi merged commit 4cb0bcb into XRPLF:develop Nov 13, 2023
16 checks passed
manojsdoshi added a commit that referenced this pull request Nov 20, 2023
* Support for the mold linker (#4807)

* Promote API version 2 to supported (#4803)

* Promote API version 2 to be supported

* Switch the command line to API version 1

* Fix LedgerRequestRPC test

* Remove obsolete tx_account method

This method is not implemented, the only parts which are removed are related to command-line parsing

* Fix RPCCall test

* Reduce diff size, small test improvements

* Minor fixes

* Support for the mold linker

* Fix TransactionEntry_test

* Fix AccountTx_test

---------

Co-authored-by: seelabs <[email protected]>

* Update Linux smoketest distros (#4813)

* Fix 2.0 regression in tx method with binary output (#4812)

* Fix binary output from tx method

* Formatting fix

* Minor test improvement

* Minor test improvements

* Optimize calculation of close time to avoid impasse and minimize gratuitous proposal changes (#4760)

* Optimize the calculation of close time to avoid
impasse and minimize gratuitous proposal changes.

* git apply clang-format.patch

* Scott S review fixes. Also clang-format.

* Set version to 2.0.0-rc2

---------

Co-authored-by: manoj <[email protected]>
Co-authored-by: Scott Determan <[email protected]>
Co-authored-by: Bronek Kozicki <[email protected]>
Co-authored-by: Michael Legleux <[email protected]>
Co-authored-by: Mark Travis <[email protected]>
ximinez pushed a commit to ximinez/rippled that referenced this pull request Nov 21, 2023
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Nov 21, 2023
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Nov 21, 2023
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants