Use platform-agnostic library names in Conan recipe

[thejohnfreeman]

Dependents like validator-keys-tool are not correctly linking to libxrpl on Windows because the library filenames are different. I believe that using the platform-agnostic names (as the linker knows them) will work. I kindly ask that @ximinez please test for me with these steps:

1. Clone this branch.
2. conan export .
3. Try to build validator-keys-tool against dependency xrpl/2.0.0-b4 (which should be the version that was exported in step 2).

[ximinez]

With the change to the library name below, and two changes to your branch in validator-keys-tool (ripple/validator-keys-tool#44), everything seems to work.

Changes:

1. Obviously, change the dependency in conanfile.txt to match the rippled version in this branch (2.0.0-b4).
2. Remove the beast::uint_test::dstream debugger output class. I don't know when it stopped working, so it's easier to just take it out for now.

Those changes are in commit ximinez/validator-keys-tool@7a70e66

[intelliot]

note: the following are blockers to merging #4831

With the change to the library name below, and two changes to your branch in validator-keys-tool (ripple/validator-keys-tool#44), everything seems to work.

Changes:

1. Obviously, change the dependency in conanfile.txt to match the rippled version in this branch (2.0.0-b4).
2. Remove the beast::uint_test::dstream debugger output class. I don't know when it stopped working, so it's easier to just take it out for now.

Those changes are in commit ximinez/validator-keys-tool@7a70e66

Update: I assume these blockers have been resolved and are no longer blocking.

[intelliot]

notes:

• the secp256k1 dependency is named secp256k1 on linux, but named libsecp256k1 on Windows
• need to figure out what names are actually being created on each platform
• figure out why they are not libname.a on Linux and name.lib on Windows
• fix CMake to produce those names and not any other names (with different names for shared libraries)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9e3658) 61.49% compared to head (0b3908b) 61.48%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4831      +/-   ##
===========================================
- Coverage    61.49%   61.48%   -0.01%     
===========================================
  Files          797      797              
  Lines        70121    70121              
  Branches     36238    36238              
===========================================
- Hits         43119    43114       -5     
- Misses       19759    19760       +1     
- Partials      7243     7247       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ximinez]

With the latest changes, I'm able to build ripple/validator-keys-tool#44 on both Windows and Linux

[intelliot]

Will Need Documentation:

1. make it easy for developers to learn how to depend on libxrpl;
2. prospective validator operators should be able to build validator-keys-tool

[intelliot]

note: this should be merged prior to ripple/validator-keys-tool#44 (the version number used in that PR will need to be updated)

@thejohnfreeman at your convenience, please:

1. Bring this branch up-to-date with the base branch (develop)
2. Indicate when, from your perspective, this PR is ready to merge. (When it's ready, we'll put the Passed label on it.)

[intelliot]

Suggested commit message:

fix(libxrpl): change library names in Conan recipe (#4831)

Use consistent platform-agnostic library names on all platforms.

Fix an issue that prevents dependents like validator-keys-tool from
linking to libxrpl on Windows.

It is bad practice to change the binary base name depending on the
platform. CMake already manipulates the base name into a final name that
fits the conventions of the platform. Linkers accept base names on the
command line and then look for conventional names on disk.