Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 Bookworm to supported distro matrix #4836

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Nov 24, 2023

High Level Overview of Change

Add codename bookworm to the distro matrix during Artifactory uploads allowing Debian 12 clients to install rippled packages.

Ignore installing conflicting core-utils packages during almalinux package smoke tests.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)

Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fi
case "$ID" in
rocky|almalinux)
pkgs="${pkgs[@]/coreutils}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;; missing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a single case within the case statement, and it's the last one. The ;; is not strictly necessary because there is no subsequent code within the case statement. However, it's good practice to still include it for consistency, especially if someone might extend this case statement in the future. Feel free to add that in a new PR.

@intelliot intelliot merged commit 2e93dd5 into XRPLF:develop Nov 27, 2023
8 checks passed
@legleux legleux deleted the add-deb12 branch January 17, 2024 07:50
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Add codename `bookworm` to the distro matrix during Artifactory uploads
allowing Debian 12 clients to install `rippled` packages.

Ignore installing conflicting `core-utils` packages during almalinux
package smoke tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants