fix: order book update variable swap: #4890

seelabs · 2024-01-18T16:16:42Z

This is likely the result of a typo when the code was simplified.

Context of Change

This was reported by @sublimator in #4790

Type of Change

[x ] Bug fix (non-breaking change which fixes an issue)

Bronek

This is good. I would also recommend reading ledger->seq() into a stack const variable once and also adding const to auto seq, but since the ledger is immutable it does not change anything except making it more explicit.

Bronek · 2024-01-19T15:22:57Z

It just occurred to me that, since Apr 2022 when the buggy code was deployed, we were more-or-less performing full book update every time (instead of the intended every 25600 ledgers). When this PR is released we will bump it to every 25600 ledgers. This will probably have performance implications.

sublimator · 2024-01-21T05:42:23Z

we were more-or-less performing full book update every time

This is just from (foggy) memory at this point, but I think the take away I got was that it was simply NOT showing new order book pairs (which doesn't really happen all that often) until a restart, and was doing LESS work if anything. But I could have been wrong and/or misremembering. But yeah, if it does start doing the work it was supposed to, I guess there will be perf implications.

intelliot · 2024-01-26T01:11:30Z

notes

This change should only affect path finding. No amendment needed.
Possible perf impact, but only back to old/previous behavior.

Internal tracker: RPFC-105

intelliot · 2024-01-26T01:14:29Z

Testable:

Notice that the bug snuck in and unit tests pass either way - that's not good.
It would be good to add a test case. Let's try to write the test.

seelabs · 2024-03-12T20:42:10Z

Rebased onto the tip of develop. Will merge after CI passes

This is likely the result of a typo when the code was simplified.

codecov-commenter · 2024-03-12T21:29:48Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.65%. Comparing base (22b7518) to head (06c46e4).
Report is 149 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/ripple/app/ledger/OrderBookDB.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4890   +/-   ##
========================================
  Coverage    61.65%   61.65%           
========================================
  Files          806      806           
  Lines        70967    70967           
  Branches     36690    36690           
========================================
+ Hits         43752    43755    +3     
+ Misses       19856    19855    -1     
+ Partials      7359     7357    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Price Oracle (XLS-47d): (XRPLF#4789) (XRPLF#4789) Implement native support for Price Oracles. A Price Oracle is used to bring real-world data, such as market prices, onto the blockchain, enabling dApps to access and utilize information that resides outside the blockchain. Add Price Oracle functionality: - OracleSet: create or update the Oracle object - OracleDelete: delete the Oracle object To support this functionality add: - New RPC method, `get_aggregate_price`, to calculate aggregate price for a token pair of the specified oracles - `ltOracle` object The `ltOracle` object maintains: - Oracle Owner's account - Oracle's metadata - Up to ten token pairs with the scaled price - The last update time the token pairs were updated Add Oracle unit-tests * fix compile error on gcc 13: (XRPLF#4932) The compilation fails due to an issue in the initializer list of an optional argument, which holds a vector of pairs. The code compiles correctly on earlier gcc versions, but fails on gcc 13. * Set version to 2.2.0-b1 * Remove default ctors from SecretKey and PublicKey: (XRPLF#4607) * It is now an invariant that all constructed Public Keys are valid, non-empty and contain 33 bytes of data. * Additionally, the memory footprint of the PublicKey class is reduced. The size_ data member is declared as static. * Distinguish and identify the PublisherList retrieved from the local config file, versus the ones obtained from other validators. * Fixes XRPLF#2942 * Fast base58 codec: (XRPLF#4327) This algorithm is about an order of magnitude faster than the existing algorithm (about 10x faster for encoding and about 15x faster for decoding - including the double hash for the checksum). The algorithms use gcc's int128 (fast MS version will have to wait, in the meantime MS falls back to the slow code). * feat: add user version of `feature` RPC (XRPLF#4781) * uses same formatting as admin RPC * hides potentially sensitive data * build: add STCurrency.h to xrpl_core to fix clio build (XRPLF#4939) * Embed patched recipe for RocksDB 6.29.5 (XRPLF#4947) * fix: order book update variable swap: (XRPLF#4890) This is likely the result of a typo when the code was simplified. * Fix workflows (XRPLF#4948) The problem was `CONAN_USERNAME` environment variable, which Conan 1.x uses as the default user in package references. * Upgrade to xxhash 0.8.2 as a Conan requirement, enable SIMD hashing (XRPLF#4893) We are currently using old version 0.6.2 of `xxhash`, as a verbatim copy and paste of its header file `xxhash.h`. Switch to the more recent version 0.8.2. Since this version is in Conan Center (and properly protects its ABI by keeping the state object incomplete), add it as a Conan requirement. Switch to the SIMD instructions (in the new `XXH3` family) supported by the new version. * Update remaining actions (XRPLF#4949) Downgrade {upload,download}-artifact action to v3 because of unreliability with v4. * Install more public headers (XRPLF#4940) Fixes some mistakes in XRPLF#4885 * test: Env unit test RPC errors return a unique result: (XRPLF#4877) * telENV_RPC_FAILED is a new code, reserved exclusively for unit tests when RPC fails. This will make those types of errors distinct and easier to test for when expected and/or diagnose when not. * Output RPC command result when result is not expected. * Fix workflows (XRPLF#4951) - Update container for Doxygen workflow. Matches Linux workflow, with newer GLIBC version required by newer actions. - Fixes macOS workflow to install and configure Conan correctly. Still fails on tests, but that does not seem attributable to the workflow. * perf: improve `account_tx` SQL query: (XRPLF#4955) The witness server makes heavily use of the `account_tx` RPC command. Perf testing showed that the SQL query used by `account_tx` became unacceptably slow when the DB was large and there was a `marker` parameter. The plan for the query showed only indexed reads. This appears to be an issue with the internal SQLite optimizer. This patch rewrote the query to use `UNION` instead of `OR` and significantly improves performance. See RXI-896 and RIPD-1847 for more details. * `fixEmptyDID`: fix amendment to handle empty DID edge case: (XRPLF#4950) This amendment fixes an edge case where an empty DID object can be created. It adds an additional check to ensure that DIDs are non-empty when created, and returns a `tecEMPTY_DID` error if the DID would be empty. * Enforce no duplicate slots from incoming connections: (XRPLF#4944) We do not currently enforce that incoming peer connection does not have remote_endpoint which is already used (either by incoming or outgoing connection), hence already stored in slots_. If we happen to receive a connection from such a duplicate remote_endpoint, it will eventually result in a crash (when disconnecting) or weird behavior (when updating slot state), as a result of an apparently matching remote_endpoint in slots_ being used by a different connection. * Remove zaphod.alloy.ee hub from default server list: (XRPLF#4903) Remove the zaphod.alloy.ee hubs from the bootstrap and default configuration after 5 years. It has been an honor to run these servers, but it is now time for another entity to step into this role. The zaphod servers will be taken offline in a phased manner keeping all those who have peering arrangements informed. These would be the preferred attributes of a boostrap set of hubs: 1. Commitment to run the hubs for a minimum of 2 years 2. Highly available 3. Geographically dispersed 4. Secure and up to date 5. Committed to ensure that peering information is kept private * Write improved `forAllApiVersions` used in NetworkOPs (XRPLF#4833) * Don't reach consensus as quickly if no other proposals seen: (XRPLF#4763) This fixes a case where a peer can desync under a certain timing circumstance--if it reaches a certain point in consensus before it receives proposals. This was noticed under high transaction volumes. Namely, when we arrive at the point of deciding whether consensus is reached after minimum establish phase duration but before having received any proposals. This could be caused by finishing the previous round slightly faster and/or having some delay in receiving proposals. Existing behavior arrives at consensus immediately after the minimum establish duration with no proposals. This causes us to desync because we then close a non-validated ledger. The change in this PR causes us to wait for a configured threshold before making the decision to arrive at consensus with no proposals. This allows validators to catch up and for brief delays in receiving proposals to be absorbed. There should be no drawback since, with no proposals coming in, we needn't be in a huge rush to jump ahead. * fixXChainRewardRounding: round reward shares down: (XRPLF#4933) When calculating reward shares, the amount should always be rounded down. If the `fixUniversalNumber` amendment is not active, this works correctly. If it is not active, then the amount is incorrectly rounded up. This patch introduces an amendment so it will be rounded down. * Remove unused files * Remove packaging scripts * Consolidate external libraries * Simplify protobuf generation * Rename .hpp to .h * Format formerly .hpp files * Rewrite includes $ find src/ripple/ src/test/ -type f -exec sed -i 's:include\s*["<]ripple/$.*$\.h$pp$\?[">]:include <ripple/\1.h>:' {} + * Fix source lists * Add markers around source lists * fix: improper handling of large synthetic AMM offers: A large synthetic offer was not handled correctly in the payment engine. This patch fixes that issue and introduces a new invariant check while processing synthetic offers. * Set version to 2.1.1 * chore: change Github Action triggers for build/test jobs (XRPLF#4956) Github Actions for the build/test jobs (nix.yml, mac.yml, windows.yml) will only run on branches that build packages (develop, release, master), and branches with names starting with "ci/". This is intended as a compromise between disabling CI jobs on personal forks entirely, and having the jobs run as a free-for-all. Note that it will not affect PR jobs at all. * Address compiler warnings * Fix search for protoc * chore: Default validator-keys-tool to master branch: (XRPLF#4943) * master is the default branch for that project. There's no point in using develop. * Remove unused lambdas from MultiApiJson_test * fix Conan component reference typo * Set version to 2.2.0-b2 * bump version * 2.2.3 * 2.2.4 * 2.2.5 --------- Co-authored-by: Gregory Tsipenyuk <[email protected]> Co-authored-by: seelabs <[email protected]> Co-authored-by: Chenna Keshava B S <[email protected]> Co-authored-by: Mayukha Vadari <[email protected]> Co-authored-by: John Freeman <[email protected]> Co-authored-by: Bronek Kozicki <[email protected]> Co-authored-by: Ed Hennis <[email protected]> Co-authored-by: Olek <[email protected]> Co-authored-by: Alloy Networks <[email protected]> Co-authored-by: Mark Travis <[email protected]> Co-authored-by: Gregory Tsipenyuk <[email protected]>

This is likely the result of a typo when the code was simplified.

seelabs requested review from Bronek and ximinez January 18, 2024 16:16

seelabs assigned Bronek and ximinez Jan 18, 2024

seelabs force-pushed the order-book-db-fix branch from 30b1a95 to 28dddb3 Compare January 18, 2024 16:17

seelabs mentioned this pull request Jan 18, 2024

[BUG] OrderBook update logic typo #4790

Open

sublimator mentioned this pull request Jan 19, 2024

Orderbook update logic Xahau/xahaud#164

Open

Bronek approved these changes Jan 19, 2024

View reviewed changes

intelliot added Bug Perf Test Desired (Optional) RippleX Perf Team should look at this PR. The PR will not necessarily wait for testing to finish labels Jan 26, 2024

intelliot added the Testable label Jan 26, 2024

ximinez approved these changes Feb 13, 2024

View reviewed changes

intelliot added this to the 2.2.0 (Apr 2024) milestone Feb 13, 2024

seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Feb 29, 2024

seelabs force-pushed the order-book-db-fix branch from 28dddb3 to d5f5903 Compare March 12, 2024 20:41

fix: order book update variable swap:

06c46e4

This is likely the result of a typo when the code was simplified.

seelabs force-pushed the order-book-db-fix branch from d5f5903 to 06c46e4 Compare March 12, 2024 21:02

seelabs merged commit ad8e976 into XRPLF:develop Mar 12, 2024
17 checks passed

sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024

fix: order book update variable swap: (XRPLF#4890)

3120592

This is likely the result of a typo when the code was simplified.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: order book update variable swap: #4890

fix: order book update variable swap: #4890

seelabs commented Jan 18, 2024

Bronek left a comment •

edited

Loading

Bronek commented Jan 19, 2024

sublimator commented Jan 21, 2024

intelliot commented Jan 26, 2024 •

edited

Loading

intelliot commented Jan 26, 2024

seelabs commented Mar 12, 2024

codecov-commenter commented Mar 12, 2024 •

edited by codecov bot

Loading

fix: order book update variable swap: #4890

fix: order book update variable swap: #4890

Conversation

seelabs commented Jan 18, 2024

Context of Change

Type of Change

Bronek left a comment • edited Loading

Choose a reason for hiding this comment

Bronek commented Jan 19, 2024

sublimator commented Jan 21, 2024

intelliot commented Jan 26, 2024 • edited Loading

intelliot commented Jan 26, 2024

seelabs commented Mar 12, 2024

codecov-commenter commented Mar 12, 2024 • edited by codecov bot Loading

Codecov Report

Bronek left a comment •

edited

Loading

intelliot commented Jan 26, 2024 •

edited

Loading

codecov-commenter commented Mar 12, 2024 •

edited by codecov bot

Loading