-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRIVIAL] Retry codecov uploads #4896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bronek
force-pushed
the
feature/retry_codecov_upload
branch
from
January 24, 2024 13:17
c20c1a9
to
c100167
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4896 +/- ##
===========================================
- Coverage 61.48% 61.48% -0.01%
===========================================
Files 797 797
Lines 70121 70121
Branches 36238 36238
===========================================
- Hits 43116 43113 -3
- Misses 19762 19763 +1
- Partials 7243 7245 +2 ☔ View full report in Codecov by Sentry. |
thejohnfreeman
approved these changes
Jan 24, 2024
this is ready to merge |
|
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 27, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 27, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
As a workaround for spurious codecov upload errors, wrap
codecov/codecov-action@v3
into awandalen/[email protected]
actionContext of Change
Spurious codecov upload errors are documented and expected in public repos which rely on PRs via forks, like we do. The underlying cause is API rate-limiting on GitHub due to the lack of access to
CODECOV_TOKEN
secret from the PR branches on forks. Although the suggested fix is to make theCODECOV_TOKEN
effectively public, this comes with security implications which we yet need to consider. Retrying uploads is a decent workaround, which we can apply easily.Type of Change
.gitignore
, formatting, dropping support for older tooling)