-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #4904
Update CONTRIBUTING.md #4904
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4904 +/- ##
=======================================
Coverage 71.0% 71.0%
=======================================
Files 796 796
Lines 66793 66793
Branches 10987 10987
=======================================
Hits 47420 47420
Misses 19373 19373 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What order are the reviewers listed in?
If there's no particular order, I think alphabetical may make sense, just so that it's not a ranking and it's not unordered.
|
||
## Current Code Reviewers | ||
|
||
Code Reviewers are developers who have the ability to review and approve source code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Reviewers are developers who have the ability to review and approve source code changes. | |
Anyone can review code changes, and all reviews are welcome. Code reviews from the following users are generally counted toward the "two" approvals that a pull request typically needs before it is merged. |
High Level Overview of Change
Update the list of Maintainers and Code Reviewers
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)