Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov coverage reporting fixes #4977

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Apr 3, 2024

High Level Overview of Change

Make codecov reporting stable by disabling plugins, disabling reporting of src/test and switching partials_as_hits

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek force-pushed the feature/codecov-improvements branch 2 times, most recently from ad0ada8 to 0c94563 Compare April 3, 2024 18:45
@Bronek Bronek force-pushed the feature/codecov-improvements branch from 0c94563 to ef438ce Compare April 3, 2024 20:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.8%. Comparing base (8b0d049) to head (0a308af).

❗ Current head 0a308af differs from pull request most recent head 69c6917. Consider uploading reports for the commit 69c6917 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4977      +/-   ##
==========================================
- Coverage     77.0%   70.8%    -6.2%     
==========================================
  Files         1129     796     -333     
  Lines       132027   66781   -65246     
  Branches     39711   11049   -28662     
==========================================
- Hits        101647   47273   -54374     
+ Misses       24502   19508    -4994     
+ Partials      5878       0    -5878     

see 779 files with indirect coverage changes

Impacted file tree graph

@Bronek Bronek force-pushed the feature/codecov-improvements branch 3 times, most recently from d1d1936 to 2b84cc3 Compare April 3, 2024 21:26
@Bronek Bronek force-pushed the feature/codecov-improvements branch 2 times, most recently from 4573dbb to d11698b Compare April 12, 2024 14:14
@Bronek Bronek force-pushed the feature/codecov-improvements branch from dd4cf4b to 7ffdb33 Compare April 12, 2024 16:05
@Bronek Bronek marked this pull request as ready for review April 12, 2024 16:59
@Bronek Bronek mentioned this pull request Apr 12, 2024
@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 18, 2024
@Bronek
Copy link
Collaborator Author

Bronek commented Apr 18, 2024

Proposed merge message:

* Amend `.codecov.yml` to disable coverage reporting of tests sources and explicitly set most parameters
* Increase codecov upload retry time to 210s (from 35s)
* Upgrade gcovr adding support for more coverage formats (lcov, clover, jacoco)
* Upgrade github actions in coverage workflow
* Explicitly disable codecov plugins (also removing `gcov` coverage, which is not correctly handled by codecov https://github.com/codecov/feedback/issues/334 )

@ximinez ximinez merged commit aae4383 into XRPLF:develop Apr 18, 2024
16 of 17 checks passed
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
* Amend `.codecov.yml` to disable coverage reporting of test sources
  and explicitly set most parameters
* Increase codecov upload retry time to 210s (from 35s)
* Upgrade gcovr adding support for more coverage formats (lcov, clover, jacoco)
* Upgrade github actions in coverage workflow
* Explicitly disable codecov plugins (also removing `gcov` coverage, which is not
  correctly handled by codecov codecov/feedback#334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants