Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Remove unused lambdas from MultiApiJson_test #4980

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Apr 4, 2024

High Level Overview of Change

This fixes "unused lambda" compiler warning, which in some settings could break compilation.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Bronek Bronek requested a review from scottschurr April 4, 2024 16:26
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (c187f75) to head (d992e63).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4980      +/-   ##
===========================================
- Coverage    76.96%   76.96%   -0.01%     
===========================================
  Files         1129     1129              
  Lines       131913   131914       +1     
  Branches     39579    39673      +94     
===========================================
- Hits        101530   101528       -2     
- Misses       24424    24491      +67     
+ Partials      5959     5895      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@ximinez ximinez merged commit d992e63 into XRPLF:develop Apr 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants