Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of maintainers: #4984

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Update list of maintainers: #4984

merged 4 commits into from
Apr 29, 2024

Conversation

nbougalis
Copy link
Contributor

I am resigning from my role as maintainer of the rippled codebase.

Please update repository permissions accordingly, prior to merging this pull request.

Thanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.

I am resigning from my role as maintainer of the `rippled` codebase.

Please update repository permissions accordingly, prior to merging this pull request.

Thanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😢

@Bronek Bronek added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.9%. Comparing base (02ec8b7) to head (6728606).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #4984     +/-   ##
=========================================
- Coverage     70.9%   70.9%   -0.0%     
=========================================
  Files          796     796             
  Lines        66792   66792             
  Branches     10998   10997      -1     
=========================================
- Hits         47378   47377      -1     
- Misses       19414   19415      +1     

see 1 file with indirect coverage changes

Impacted file tree graph

@ximinez ximinez merged commit dccf3f4 into develop Apr 29, 2024
18 of 19 checks passed
@ximinez ximinez deleted the nbougalis-patch-1 branch April 29, 2024 22:44
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
I am resigning from my role as maintainer of the `rippled` codebase.

Please update repository permissions accordingly, prior to merging this pull request.

Thanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants